From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA] gdb/win32-nat.c Step the correct thread
Date: Thu, 29 Nov 2007 15:45:00 -0000 [thread overview]
Message-ID: <002801c8329e$d726e090$8574a1b0$@u-strasbg.fr> (raw)
While trying to understand the SuspendThread
counting problems, I tried to single step after changing
thread, and I noticed that the next event always
brought me back to the main thread.
There is a bug in the current win32-nat.c source
which places the trace bit always in the
main thread, while we should step the thread identified by
inferior_ptid.
This simple patch corrects this.
The testsuite runs with and without this patch
show no difference.
OK to check in?
2007-11-29 Pierre Muller <muller@ics.u-strasbg.fr>
* win32-nat.c (win32_resume): Set the trace bit
in the thread identified by inferior_ptid.
Index: gdb/win32-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/win32-nat.c,v
retrieving revision 1.140
diff -u -p -r1.140 win32-nat.c
--- gdb/win32-nat.c 24 Nov 2007 12:13:28 -0000 1.140
+++ gdb/win32-nat.c 29 Nov 2007 13:52:18 -0000
@@ -1225,7 +1225,7 @@ win32_resume (ptid_t ptid, int step, enu
pid, step, sig));
/* Get context for currently selected thread */
- th = thread_rec (current_event.dwThreadId, FALSE);
+ th = thread_rec (PIDGET (inferior_ptid), FALSE);
if (th)
{
if (step)
next reply other threads:[~2007-11-29 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 15:45 Pierre Muller [this message]
2007-12-02 2:46 ` Christopher Faylor
2007-12-02 21:53 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002801c8329e$d726e090$8574a1b0$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox