From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4970 invoked by alias); 24 Sep 2003 01:20:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4923 invoked from network); 24 Sep 2003 01:20:08 -0000 Received: from unknown (HELO hub.ott.qnx.com) (209.226.137.76) by sources.redhat.com with SMTP; 24 Sep 2003 01:20:08 -0000 Received: from smtp.ott.qnx.com (smtp.ott.qnx.com [10.0.2.158]) by hub.ott.qnx.com (8.9.3/8.9.3) with ESMTP id VAA30181; Tue, 23 Sep 2003 21:18:18 -0400 Received: from dash ([192.168.20.33]) by smtp.ott.qnx.com (8.8.8/8.6.12) with SMTP id VAA24901; Tue, 23 Sep 2003 21:20:06 -0400 Message-ID: <002601c3823a$209cd910$6400a8c0@dash> From: "Kris Warkentin" To: "Elena Zannoni" Cc: References: <16240.46973.557418.422147@localhost.redhat.com> Subject: Re: [Patch] fix for PR:1291 Date: Wed, 24 Sep 2003 01:20:00 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 X-SW-Source: 2003-09/txt/msg00516.txt.bz2 > kewarken writes: > > Credit to inaba@src.ricoh.co.jp for his original find and patch and to > > Colin Burgess for noting the differences between gcc 2 and 3. > > > > ChangeLog: > > > > 2003-09-16 Kris Warkentin > > > > * sh-tdep.c: Properly detect frame prologues for functions with > > more than 256 bytes of local variables. > > You should give credit to these folks in the changelog entry. Certainly. > I wonder if this can be captured in a test case? How does your change > interacts with Corinna's rewrite? I'll take a look at it when I have some more time next week. The test case is very simple so I can easily check to see if Corinna's stuff fixes it. Unfortunately my available gdb cycles have been extremely low lately since we have a lot of critical internal stuff that I've been grabbed for. cheers, Kris