From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12255 invoked by alias); 30 May 2008 15:13:12 -0000 Received: (qmail 12245 invoked by uid 22791); 30 May 2008 15:13:11 -0000 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 30 May 2008 15:12:52 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id m4UFCgMF060724 ; Fri, 30 May 2008 17:12:42 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402::142]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id m4UFCgR1095931 ; Fri, 30 May 2008 17:12:42 +0200 (CEST) Received: from d620muller (laocoon.u-strasbg.fr [130.79.112.72]) by mailserver.u-strasbg.fr (8.13.8/jtpda-5.5pre1) with ESMTP id m4UFCdGL045154 ; Fri, 30 May 2008 17:12:42 +0200 (CEST) From: "Pierre Muller" To: "'Mark Kettenis'" Cc: , , References: <004f01c8ac58$06a1ddb0$13e59910$@u-strasbg.fr> <000c01c8c246$de300f50$9a902df0$@u-strasbg.fr> <200805301157.m4UBvOL5009408@brahms.sibelius.xs4all.nl> <001901c8c256$06f8be00$14ea3a00$@u-strasbg.fr> <001a01c8c263$f493b1d0$ddbb1570$@u-strasbg.fr> <200805301457.m4UEvnGD028393@brahms.sibelius.xs4all.nl> In-Reply-To: <200805301457.m4UEvnGD028393@brahms.sibelius.xs4all.nl> Subject: RE: [PING2] : [RFC/RFA] PING: skip __main Date: Sat, 31 May 2008 02:30:00 -0000 Message-ID: <002501c8c267$9c4b9c00$d4e2d400$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (mailhost.u-strasbg.fr [IPv6:2001:660:2402::156]); Fri, 30 May 2008 17:12:42 +0200 (CEST) X-Virus-Status: Clean Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-05/txt/msg00774.txt.bz2 I restarted a testsuite, but I=20 won't expect any change because=20 main seems to be at a lower address than __main in the few executables I tested, meaning that the value in buf will be positive anyhow. Pierre Muller Pascal language support maintainer for GDB -----Message d'origine----- De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] De la part de Mark Kettenis Envoy=E9=A0: Friday, May 30, 2008 4:58 PM =C0=A0: muller@ics.u-strasbg.fr Cc=A0: pedro@codesourcery.com; drow@false.org; gdb-patches@sourceware.org Objet=A0: Re: [PING2] : [RFC/RFA] PING: skip __main > From: "Pierre Muller" > Date: Fri, 30 May 2008 16:46:28 +0200 >=20 > + target_read_memory (pc, &op, 1); > + if (op =3D=3D 0xe8) > + { > + gdb_byte buf[4]; > + > + if (target_read_memory (pc + 1, buf, sizeof buf) =3D=3D 0) > + { > + CORE_ADDR call_dest =3D pc + 5 + extract_unsigned_integer (buf, 4); > Just one small question about this line: > I fear that this line is incorrect, > shouldn't we use extract_signed_integer here? >=20 > The address is relative to pc+5 meaning that > if main is at a higher address than __main, > buf will contain a negative 4byte integer. You're absolutely right. Can you make that change and retest?