From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17443 invoked by alias); 5 Apr 2010 22:48:57 -0000 Received: (qmail 17423 invoked by uid 22791); 5 Apr 2010 22:48:40 -0000 X-SWARE-Spam-Status: No, hits=3.6 required=5.0 tests=BAYES_00,KAM_STOCKTIP,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Apr 2010 22:48:35 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o35Mm9rD099106 ; Tue, 6 Apr 2010 00:48:10 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o35Mm9hu033042 ; Tue, 6 Apr 2010 00:48:09 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o35Mm8D8056587 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 6 Apr 2010 00:48:08 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: References: <000201cac54d$246dcdd0$6d496970$@muller@ics-cnrs.unistra.fr> <20100323185314.GA2882@adacore.com> <000601cacba5$0463eb60$0d2bc220$@muller@ics-cnrs.unistra.fr> <20100405151916.GB19194@adacore.com> In-Reply-To: <20100405151916.GB19194@adacore.com> Subject: RE: [RFC-v2] Support for const char and strings in stabs reader Date: Mon, 05 Apr 2010 22:48:00 -0000 Message-ID: <002401cad512$1412bb60$3c383220$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00085.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Joel Brobecker > Envoy=E9=A0: Monday, April 05, 2010 5:19 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFC-v2] Support for const char and strings in stabs reader >=20 > > > As a general comment, the formatting of the section supporting > strings > > > is not consistent. It looks like it's because you have a mixture of > > > spaces and tabs... > > Strange because I now use the script recently given on gdb mailing > list > > to avoid such problems... >=20 > The tricks for the .vimrc file is not a silver bullet ensuring that all > lines start with tabs instead of using blocks of 8 spaces. What it only > does is use tabs instead of spaces when creating a new line. Some parts > of your patch have lines that start with a space, then a tab, then more > spaces... >=20 > When you need to see spaces and tabs, I recommend the following > setting: >=20 > :set list >=20 > I cannot help shaking my head as to how much grief this spaces vs tabs > thing is causing. It's insane, IMO, to be clinging to tabs in our > programming style. But I've fought and lost that battle before... >=20 Thanks for that advice, it was still a pain to convert, but at least I see what Ido! =20 > > 2010-03-24 Pierre Muller > > > > * stabsread.c (define_symbol): Add support for char > > and string constants. >=20 > This is OK, after you make sure to format the code properly (spaces > and tabs). Done, hopefully without errors. > > testsuite ChangeLog entry: > > > > * gdb.stabs/aout.sed: Convert all backslash to double backslash > > within one line, unless it is followed by a double quote. > > * gdb.stabs/hppa.sed: Idem. > > * gdb.stabs/weird.def: Add char and String constants > > * gdb.stabs/weird.exp: Check for correct parsing of > > chhar and string constants. > > * gdb.stabs/xcoff.sed: Ignore escaped quote quotes > > in .stabs to .stabx substitution. >=20 > OK, except for one tiny hunk that I suspect got in unintentionally: >=20 > > @@ -287,7 +298,7 @@ if { [gdb_compile "${srcfile}" "${binfi > > return -1 > > } > > > > -remote_file build delete ${srcfile} > > +# remote_file build delete ${srcfile} > > > > # Start with a fresh gdb > > gdb_exit >=20 > This change was probably not meant to go in. Nice catch, of course not, I just used it to inspect that generated assembler file. Committed after applying your requests, thanks, Pierre