From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16747 invoked by alias); 22 May 2012 15:15:20 -0000 Received: (qmail 16735 invoked by uid 22791); 22 May 2012 15:15:18 -0000 X-SWARE-Spam-Status: No, hits=2.2 required=5.0 tests=AWL,BAYES_00,KHOP_DNSBL_BUMP,KHOP_THREADED,MSGID_MULTIPLE_AT,RCVD_IN_HOSTKARMA_BL,RCVD_IN_JMF_BL,TW_CP X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 May 2012 15:15:05 +0000 Received: from md13.u-strasbg.fr (md13.u-strasbg.fr [130.79.200.248]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q4MFExjd023375 ; Tue, 22 May 2012 17:14:59 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms14.u-strasbg.fr [130.79.204.114]) by md13.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q4MFExD4012188 ; Tue, 22 May 2012 17:14:59 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id q4MFEwNj001276 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Tue, 22 May 2012 17:14:58 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Pedro Alves'" , References: <4fbb59b7.44e2440a.48c4.ffffab13SMTPIN_ADDED@mx.google.com> <4FBB5D9B.5070202@redhat.com> <000c01cd3813$32090b40$961b21c0$@muller@ics-cnrs.unistra.fr> <20120522121832.GC5492@adacore.com> <4FBB88C5.6070900@redhat.com> In-Reply-To: <4FBB88C5.6070900@redhat.com> Subject: [RFA-v3/ARI fix] Remove use of abort function in common/buffer.c Date: Tue, 22 May 2012 15:15:00 -0000 Message-ID: <002101cd382d$a5eb2fb0$f1c18f10$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00824.txt.bz2 > Fine with me, but I'd suggest to just say nothing. The whole point of the > xrealloc, > xmalloc, etc. functions is to abort on failure instead of returning NULL. > We have > about 150 or so xrealloc calls in the tree, about 70 xcalloc calls, and > about 700 xmalloc calls. We don't put just comment on most (any?) of those, > and > I don't see what makes this particular instance special. You are right, OK for that even simpler patch? 2012-05-22 Pierre Muller * common/buffer.c (buffer_grow): ARI fix: Remove unneeded call to abort. Index: common/buffer.c =================================================================== RCS file: /cvs/src/src/gdb/common/buffer.c,v retrieving revision 1.3 diff -u -p -r1.3 buffer.c --- common/buffer.c 11 May 2012 22:24:22 -0000 1.3 +++ common/buffer.c 22 May 2012 15:13:24 -0000 @@ -47,8 +47,6 @@ buffer_grow (struct buffer *buffer, cons while (buffer->used_size + size > new_buffer_size) new_buffer_size *= 2; new_buffer = xrealloc (buffer->buffer, new_buffer_size); - if (!new_buffer) - abort (); memcpy (new_buffer + buffer->used_size, data, size); buffer->buffer = new_buffer; buffer->buffer_size = new_buffer_size;