From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6435 invoked by alias); 5 Apr 2010 22:19:46 -0000 Received: (qmail 6423 invoked by uid 22791); 5 Apr 2010 22:19:43 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Apr 2010 22:19:36 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o35MJCu6023594 ; Tue, 6 Apr 2010 00:19:12 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o35MJBSN005486 ; Tue, 6 Apr 2010 00:19:11 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o35MJAVY088930 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 6 Apr 2010 00:19:11 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: References: <002401cad1ab$a8163180$f8429480$@muller@ics-cnrs.unistra.fr> <20100405163845.GE19194@adacore.com> In-Reply-To: <20100405163845.GE19194@adacore.com> Subject: RE: [RFA] ARI fix: remove remaining %ll occurences. Date: Mon, 05 Apr 2010 22:19:00 -0000 Message-ID: <002101cad50e$0860a3d0$1921eb70$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00083.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Joel Brobecker > Envoy=E9=A0: Monday, April 05, 2010 6:39 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] ARI fix: remove remaining %ll occurences. >=20 > > As there is no way LONGEST can be specified for scanf, > > I took the option to allow %ll inside scanf calls. >=20 > I don't have a better alternative to propose. Since this does not seem > to be a portability issue so far, I'm OK with that. Great, I updated the gdb_ari.sh for this. =20 > > 2010-04-01 Pierre Muller > > > > Remove remaining "%ll" uses. > > * go32-nat.c (go32_pte_for_address): Replace "0x%llx" using > > hex_string call. > > * rs6000-nat.c (rs6000_ptrace64): Idem. > > * solib-pa64.c (pa64_current_sos): Idem. > > * solib-spu.c (spu_current_sos): Idem. > > * linux-nat.c (linux_nat_find_memory_regions): Replace "%lld" > using > > plongest call. > > * nto-procfs.c (procfs_meminfo): Replace "0x%016llx" using > > phex (VAR, 8) call. > > * sh64-tdep.c (sh64_show_media_regs): Idem. >=20 > Just one typo, but otherwise approved. Thank you for doing that. >=20 > > - ("PC=3D%s SR=3D%016llx \n", > > + ("PC=3D%s SR=3D%s \n", > > phex (get_frame_register_unsigned (frame, > > gdbarch_pc_regnum (gdbarch)), 8), > > - (long long) get_frame_register_unsigned (frame, SR_REGNUM)); > > + phex (get_frame_register_unsigned (frame, SR_REGNUM), 9)); > ^^^^ > Typo: Should be 8. Whoops, my hands are not precise enough for a keyboard, it seems... Committed with that change, Thanks Joel, Pierre