From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15981 invoked by alias); 13 Dec 2012 15:17:10 -0000 Received: (qmail 15961 invoked by uid 22791); 13 Dec 2012 15:17:09 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Dec 2012 15:17:05 +0000 Received: from md14.u-strasbg.fr (md14.u-strasbg.fr [130.79.200.249]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBDFH0O7077415 ; Thu, 13 Dec 2012 16:17:00 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms18.u-strasbg.fr [130.79.204.118]) by md14.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBDFGx0u025100 ; Thu, 13 Dec 2012 16:17:00 +0100 Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBDFGxep006329 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Thu, 13 Dec 2012 16:16:59 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: "'GDB Patches'" References: <20121024194517.GK3555@adacore.com> <011901cdb2ab$48076b90$d81642b0$@muller@ics-cnrs.unistra.fr> <20121105171121.GA2972@adacore.com> <50991f5f.8382440a.1100.ffff82abSMTPIN_ADDED@mx.google.com> <509ABA17.30507@redhat.com> <000301cdbd96$f5cd9f10$e168dd30$@muller@ics-cnrs.unistra.fr> <20121122173019.GF9964@adacore.com> <15690.5992342674$1353883881@news.gmane.org> <87624si9ur.fsf@fleche.redhat.com> <001501cdccaf$ad85e9b0$0891bd10$@muller@ics-cnrs.unistra.fr> <20121207071035.GG31477@adacore.com> <50C20A66.70002@gmail.com> <29545.4593528577$1354894901@news.gmane.org> <50C21696.7040006@gmail.com> <50c21914.a750420a.2ec3.ffffe4ffSMTPIN_ADDED_BROKEN@mx.google.com> <50C222D5.4000802@redhat.com> <50C22C20.8090906@redhat.com> <008101cdd920$907e7580$b17b6080$@muller@ics-cnrs.unistra.fr> <50C9B6E0.1050709@redhat.com> <00a201cdd931$b0ee13f0$12ca3bd0$@muller@ics-cnrs.unistra.fr> <50C9E706.2020708@redhat.com> In-Reply-To: <50C9E706.2020708@redhat.com> Subject: RE: [RFC-v5] Fix .text section offset for windows DLL (was Calling __stdcall functions in the inferior) Date: Thu, 13 Dec 2012 15:17:00 -0000 Message-ID: <001e01cdd944$e6c92d80$b45b8880$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00450.txt.bz2 > >> I'm still curious on why you needed the #ifndefs though. > > > > Oh, I forgot that one, > > I will test without the ifdef's... > > These across are defined in mingw32 winnh.h header > > and also for cygwin in > > /usr/include/aout.h > > /usr/include/w32api/winnt.h > > as well as in > > /usr/include/w32api/ddk/ntimage.h > > > > and I was afraid that such a header could be included indirectly > > by some of the other headers. > > I don't think that's very likely. That'd mean that coff/pe.h would > need guards for its related definitions too. > > > Below is a patch to remove the unneeded checks... > > > > 2012-12-13 Pierre Muller > > > > * coff-pe-read.c (IMAGE_SCN_CNT_TEXT, > IMAGE_SCN_CNT_INITIALIZED_DATA) > > (IMAGE_SCN_CNT_UNINITIALIZED_DATA): Remove useless checks > > for already defined macros. > > > > Index: coff-pe-read.c > > =================================================================== > > RCS file: /cvs/src/src/gdb/coff-pe-read.c,v > > retrieving revision 1.19 > > diff -u -p -r1.19 coff-pe-read.c > > --- coff-pe-read.c 13 Dec 2012 10:44:45 -0000 1.19 > > +++ coff-pe-read.c 13 Dec 2012 12:46:09 -0000 > > @@ -55,15 +55,9 @@ struct read_pe_section_data > > char *section_name; /* Recorded section name. */ > > }; > > > > -#ifndef IMAGE_SCN_CNT_CODE > > # define IMAGE_SCN_CNT_CODE 0x20 > > The spaces in "# define" should be removed too. Okay with that change. Thanks committed with your change applied. And my apologies for the cross-post about the coff/internal.h header need. Pierre