From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51210-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22377 invoked by alias); 9 Oct 2007 07:02:43 -0000
Received: (qmail 22356 invoked by uid 22791); 9 Oct 2007 07:02:40 -0000
X-Spam-Check-By: sourceware.org
Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Oct 2007 07:02:36 +0000
Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) 	by ics.u-strasbg.fr (Postfix) with ESMTP id 90AF4187020; 	Tue,  9 Oct 2007 09:07:17 +0200 (CEST)
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Pedro Alves'" <pedro_alves@portugalmail.pt>, 	"'Joel Brobecker'" <brobecker@adacore.com>, 	<gdb-patches@sourceware.org>
References: <46F707C3.1090105@portugalmail.pt> <006101c7fe8b$70d5af70$52810e50$@u-strasbg.fr> <4053daab0709240321n40d7e3e0vc0f7d5567e990785@mail.gmail.com> <006701c7feae$fbb75850$f32608f0$@u-strasbg.fr> <46F8C1C8.7080608@portugalmail.pt> <46F9A061.2020909@portugalmail.pt> <001b01c805b5$ce7f0730$6b7d1590$@u-strasbg.fr> <20071003184156.GC4305@adacore.com> <20071003185126.GA1976@caradoc.them.org> <47040AD9.6000900@portugalmail.pt> <20071003214038.GA26617@caradoc.them.org> <47060AD9.2070701@portugalmail.pt> <470ABA35.2030407@portugalmail.pt>
In-Reply-To: <470ABA35.2030407@portugalmail.pt>
Subject: RE: [RFC] Stabs parsing regression from GDB 6.6 to GDB 6.6.90
Date: Tue, 09 Oct 2007 09:10:00 -0000
Message-ID: <001e01c80a42$6530b7b0$2f922710$@u-strasbg.fr>
MIME-Version: 1.0
Content-Type: text/plain; 	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Content-Language: en-us
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00188.txt.bz2

Pedro,

you patch to main leads to a warning when compiling stabsread.o
because sign_bit might be used uninitialized.
  Even though this is a false alarm,
as sign_bit is set if two_complement_representation is,
and used later only if two_complement_representation is set;
we need to correct this, as it leads to a compilation failure if
-Werror is used.

gcc -c -g -O2    -I. -I../../src/gdb -I../../src/gdb/config
-DLOCALEDIR="\"/usr/
local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode
-I../../
src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd
-I../../src/gdb/../includ
e   -DMI_OUT=1 -DTUI=1  -Wall -Wdeclaration-after-statement -Wpointer-arith
-Wfo
rmat-nonliteral -Wno-unused -Wno-switch -Wno-char-subscripts -Werror
version.c
gcc -c -g -O2    -I. -I../../src/gdb -I../../src/gdb/config
-DLOCALEDIR="\"/usr/
local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode
-I../../
src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd
-I../../src/gdb/../includ
e   -DMI_OUT=1 -DTUI=1  -Wall -Wdeclaration-after-statement -Wpointer-arith
-Wfo
rmat-nonliteral -Wno-unused -Wno-switch -Wno-char-subscripts -Werror
../../src/g
db/stabsread.c
../../src/gdb/stabsread.c: In function `read_huge_number':
../../src/gdb/stabsread.c:3736: warning: 'sign_bit' might be used
uninitialized
in this function
make[1]: *** [stabsread.o] Error 1
make[1]: Leaving directory `/usr/local/src/cvs/build/gdb'
make: *** [all-gdb] Error 2

Declaring it with initial value = 0
is enough to fix the compilation failure.

Pierre