From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25285 invoked by alias); 28 May 2009 16:22:37 -0000 Received: (qmail 25272 invoked by uid 22791); 28 May 2009 16:22:35 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 May 2009 16:22:26 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n4SGM7o0024453 ; Thu, 28 May 2009 18:22:07 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n4SGM6EL030665 ; Thu, 28 May 2009 18:22:06 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n4SGM6sj027073 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 28 May 2009 18:22:06 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Cc: References: <001001c9df7b$8f2a3810$ad7ea830$@u-strasbg.fr> In-Reply-To: Subject: RE: [RFA] Build failure fix: Python troubles on non-python targets... Date: Thu, 28 May 2009 16:22:00 -0000 Message-ID: <001c01c9dfb0$74dfec40$5e9fc4c0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00608.txt.bz2 Here is what I get if I move it down: $ make make[1]: Entering directory `/usr/local/src/gdbcvs/build-nopython/gdb' make[2]: Entering directory `/usr/local/src/gdbcvs/build-nopython/gdb/gnulib' make all-am make[3]: Entering directory `/usr/local/src/gdbcvs/build-nopython/gdb/gnulib' if gcc -DHAVE_CONFIG_H -I. -I../../../purecvs/gdb/gnulib -I.. -gstabs+ -O0 - MT memmem.o -MD -MP -MF ".deps/memmem.Tpo" -c -o memmem.o ../../../purecvs/gdb/g nulib/memmem.c; \ then mv -f ".deps/memmem.Tpo" ".deps/memmem.Po"; else rm -f ".deps/memme m.Tpo"; exit 1; fi rm -f libgnu.a ar cru libgnu.a dummy.o memmem.o ranlib libgnu.a make[3]: Leaving directory `/usr/local/src/gdbcvs/build-nopython/gdb/gnulib' make[2]: Leaving directory `/usr/local/src/gdbcvs/build-nopython/gdb/gnulib' make[1]: Leaving directory `/usr/local/src/gdbcvs/build-nopython/gdb' gcc -gstabs+ -O0 -I. -I../../purecvs/gdb -I../../purecvs/gdb/common -I../../pu recvs/gdb/config -DLOCALEDIR=3D"\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../ ../purecvs/gdb/../include/opcode -I../../purecvs/gdb/../readline/.. -I../bfd -I. ./../purecvs/gdb/../bfd -I../../purecvs/gdb/../include -I../libdecnumber -I../.. /purecvs/gdb/../libdecnumber -I../../purecvs/gdb/gnulib -Ignulib -DMI_OUT=3D1 -D TUI=3D1 -DGDBTK -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonl iteral -Wno-unused -Wno-switch -Wno-char-subscripts -Werror -c -o python-prettyp rint.o -MT python-prettyprint.o -MMD -MP -MF .deps/python-prettyprint.Tpo ../.. /purecvs/gdb/python/python-prettyprint.c ../../purecvs/gdb/python/python-prettyprint.c:598: error: conflicting types for 'apply_val_pretty_printer' ../../purecvs/gdb/python/python.h:33: error: previous declaration of 'apply_val_ pretty_printer' was here ../../purecvs/gdb/python/python-prettyprint.c:598: error: conflicting types for 'apply_val_pretty_printer' ../../purecvs/gdb/python/python.h:33: error: previous declaration of 'apply_val_ pretty_printer' was here make: *** [python-prettyprint.o] Error 1 Pierre > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Thursday, May 28, 2009 5:32 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] Build failure fix: Python troubles on non-python > targets... >=20 > >>>>> "Pierre" =3D=3D Pierre Muller writes: >=20 > Pierre> On DJGPP, > Pierre> I now get this failure: > [...] >=20 > Sorry about that. >=20 > Pierre> The following two changes fixes compilation for me: > Pierre> Is this patch OK? >=20 > Nearly... >=20 > Pierre> + > Pierre> +#ifdef HAVE_PYTHON > Pierre> + > Pierre> #include "python.h" > Pierre> #include "python-internal.h" >=20 > This should unconditionally include python.h. So, the conditional > needs to be moved down a few lines. It is ok to include python.h even > if Python is not available; and in this case it is desirable so that > the declarations are picked up (and thus checked against the > definitions). >=20 > Ok with that change. Thanks. >=20 > Tom