From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28981 invoked by alias); 12 Nov 2012 09:17:26 -0000 Received: (qmail 28969 invoked by uid 22791); 12 Nov 2012 09:17:25 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT,TW_BJ X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Nov 2012 09:17:18 +0000 Received: from md14.u-strasbg.fr (md14.u-strasbg.fr [130.79.200.249]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAC9HBBk005509 ; Mon, 12 Nov 2012 10:17:11 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms14.u-strasbg.fr [130.79.204.114]) by md14.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAC9HAHj004024 ; Mon, 12 Nov 2012 10:17:10 +0100 Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qAC9H9gi028869 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Mon, 12 Nov 2012 10:17:09 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: , References: <20121106015848.GA5296@sourceware.org> <5098efb2.05fd440a.7696.ffffd821SMTPIN_ADDED@mx.google.com> <50995EBB.6070503@redhat.com> In-Reply-To: <50995EBB.6070503@redhat.com> Subject: PING: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012 Date: Mon, 12 Nov 2012 09:17:00 -0000 Message-ID: <001b01cdc0b6$7e7b67d0$7b723770$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00280.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: mardi 6 novembre 2012 20:02 > =C0=A0: Pierre Muller > Cc=A0: devans@sourceware.org; gdb-patches@sourceware.org > Objet=A0: Re: [RFA] Fix New ARI warning Tue Nov 6 01:58:48 UTC 2012 >=20 > On 11/06/2012 11:08 AM, Pierre Muller wrote: >=20 > >> 281a282,283 > >>> gdb/dwarf2read.c:8612: regression: xasprintf: Do not use xasprintf(), > >> instead use xstrprintf > >> gdb/dwarf2read.c:8612: xasprintf (&virtual_dwo_name, ', > >>> gdb/dwarf2read.c:8984: regression: xasprintf: Do not use xasprintf(), > >> instead use xstrprintf > >> gdb/dwarf2read.c:8984: xasprintf (&dwp_name, ', dwarf2_per_objfile- > >>> objfile->name); > > > > Doug, > > > > could you check the patch below > > which removes the new ARI warnings about use of > > xasprintf function in the commit > > > > http://sourceware.org/ml/gdb-cvs/2012-11/msg00027.html Doug didn't reply yet to this RFA... =20 > D=E9j=E0 vu :-) >=20 > http://sourceware.org/ml/gdb-patches/2009-03/msg00576.html >=20 > This removes the last use of xasprintf in the tree; we should delete > it to avoid new uses creeping in. There is probably a list of other similar functions that we should obsolete. The main question is, should we do it brutally or softly. 1-- Brutal method: Remove function from both header and C sources as well as from ARI script. 2 -- Soft method: Start by simply removing function from header. Change function to static. Wait for one release and suppress completely. Method 1 is simpler, but not adapted to some functions that are used internally. Method 2 is gentler to outsiders using gdb sources for external projects, like the inclusion of libgdb.a into the Free Pascal IDE, which I basically try to maintain... Yes, I know I should be using mi, but I never got to=20 switch :( Pierre Muller=20 as ARI maintainer