From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32538 invoked by alias); 30 Nov 2016 23:34:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32528 invoked by uid 89); 30 Nov 2016 23:34:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:445, modulo, H*MI:google, H*M:google X-HELO: mail-io0-f202.google.com Received: from mail-io0-f202.google.com (HELO mail-io0-f202.google.com) (209.85.223.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 23:34:35 +0000 Received: by mail-io0-f202.google.com with SMTP id r94so11732985ioe.0 for ; Wed, 30 Nov 2016 15:34:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:message-id:date:subject:from:to:cc; bh=hODt/ghmdMV6EkKzUQyYwlZYIrC0orUdP1vMa2FgQZM=; b=fYgaDrFBOU59BkJHhnPK4yxwHbNLC3dNn4mkfNaevmY6MntHq5mkj2uZrwogimpFHD 035NldqH4W9zsg+0waa7TvnVZDAOWXyx+dRyg61zFVp5iSsw6H0q2Lv5DeFwuO/nkIVw KoSprHd1+lsiuGVkFduNwU6rLkTAO+oU3wdKLj3GWeTTs9Qqn4KAz/dIqiKOBpd5V6AF TYw1Q0CsejuuG/Y05aMnt/StODQFIgb0jbgw3mGeNBTEdCJ8nQZLhOHrpB+Py+QTgf1B XiK4qT8iwGR+9BilrhuS76k/GWb/Xln21QLswHpPsgbVCcq/9XwU6nsSwgOhVWz/mnRO P+rg== X-Gm-Message-State: AKaTC01UHI1J5iA3nFzS/6moQDL8oa6uixkclW1/nVq15PUpR4p8GQZ4BYTP6YNVn2Ef7h8fwg== MIME-Version: 1.0 X-Received: by 10.157.43.70 with SMTP id f6mr7756675otd.129.1480548871839; Wed, 30 Nov 2016 15:34:31 -0800 (PST) Message-ID: <001a113ccf389467b905428d2508@google.com> Date: Wed, 30 Nov 2016 23:34:00 -0000 Subject: Re: [PATCH v3 2/8] btrace: Export btrace_decode_error function. From: Doug Evans To: Tim Wiederhake Cc: gdb-patches@sourceware.org, palves@redhat.com, markus.t.metzger@intel.com Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg01035.txt.bz2 Tim Wiederhake writes: > 2016-11-21 Tim Wiederhake > > gdb/ChangeLog: > > * record-btrace.c (btrace_ui_out_decode_error): Move most of it ... > * btrace.c (btrace_decode_error): ... here. New function. > * btrace.h (btrace_decode_error): New export. Hi. LGTM (modulo anything Markus or someone else wrote, I read the comments but have since forgotten)