From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19299 invoked by alias); 12 Jun 2014 03:40:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19289 invoked by uid 89); 12 Jun 2014 03:40:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jun 2014 03:40:05 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 12 Jun 2014 04:40:02 +0100 Received: from shawin252 ([10.164.2.187]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 12 Jun 2014 04:39:54 +0100 From: "Terry Guo" To: , "'Will Newton'" Cc: References: <000b01cf8540$dafa6d80$90ef4880$@arm.com> <001701cf8555$40925540$c1b6ffc0$@arm.com> <53983C82.4040208@codesourcery.com> In-Reply-To: <53983C82.4040208@codesourcery.com> Subject: RE: [Patch]Clean up the XML files for ARM Date: Thu, 12 Jun 2014 03:40:00 -0000 Message-ID: <001801cf85ef$f9decd40$ed9c67c0$@arm.com> MIME-Version: 1.0 X-MC-Unique: 114061204400200201 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00485.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Luis Machado > Sent: Wednesday, June 11, 2014 7:25 PM > To: Terry Guo; 'Will Newton' > Cc: gdb-patches@sourceware.org > Subject: Re: [Patch]Clean up the XML files for ARM >=20 > On 06/11/2014 10:12 AM, Terry Guo wrote: > > > > > >> -----Original Message----- > >> From: Will Newton [mailto:will.newton@linaro.org] > >> Sent: Wednesday, June 11, 2014 4:16 PM > >> To: Terry Guo > >> Cc: gdb-patches@sourceware.org > >> Subject: Re: [Patch]Clean up the XML files for ARM > >> > >> On 11 June 2014 07:46, Terry Guo wrote: > >>> Hi There, > >>> > >>> Under folder gdb/features we are having more and more ARM related > >>> XML > >> files. > >>> This patch intends to move those ARM XML files into a new folder > >>> named > >> arm. > >>> All the references to those files are now prefixed with folder name a= rm. > >>> Please be noted that this doesn't include AArch64 XML files so far. > >>> Is it ok to GDB trunk? > >>> > >>> BR, > >>> Terry > >>> > >>> 2014-06-11 Terry Guo > >>> > >>> * features/arm-core.xml: Move to ... > >>> * features/arm/arm-core.xml: ... here. > >>> * features/arm-fpa.xml: Move to ... > >>> * features/arm/arm-fpa.xml: ... here. > >>> * features/arm-m-profile.xml: Move to ... > >>> * features/arm/arm-m-profile.xml: ... here. > >>> * features/arm-vfpv2.xml: Move to ... > >>> * features/arm/arm-vfpv2.xml: ... here. > >>> * features/arm-vfpv3.xml: Move to ... > >>> * features/arm/arm-vfpv3.xml: ... here. > >>> * features/arm-with-iwmmxt.xml: Move to ... > >>> * features/arm/arm-with-iwmmxt.xml: ... here. > >>> * features/arm-with-iwmmxt.c: Move to ... > >>> * features/arm/arm-with-iwmmxt.c: ... here. > >>> * features/arm-with-m.xml: Move to ... > >>> * features/arm/arm-with-m.xml: ... here. > >>> * features/arm-with-m.c: Move to ... > >>> * features/arm/arm-with-m.c: ... here. > >>> * features/arm-with-m-fpa-layout.xml: Move to ... > >>> * features/arm/arm-with-m-fpa-layout.xml: ... here. > >>> * features/arm-with-m-fpa-layout.c: Move to ... > >>> * features/arm/arm-with-m-fpa-layout.c: ... here. > >>> * features/arm-with-m-vfp-d16.xml: Move to ... > >>> * features/arm/arm-with-m-vfp-d16.xml: ... here. > >>> * features/arm-with-m-vfp-d16.c: Move to ... > >>> * features/arm/arm-with-m-vfp-d16.c: ... here. > >>> * features/arm-with-neon.xml: Move to ... > >>> * features/arm/arm-with-neon.xml: ... here. > >>> * features/arm-with-neon.c: Move to ... > >>> * features/arm/arm-with-neon.c: ... here. > >>> * features/arm-with-vfpv2.xml: Move to ... > >>> * features/arm/arm-with-vfpv2.xml: ... here. > >>> * features/arm-with-vfpv2.c: Move to ... > >>> * features/arm/arm-with-vfpv2.c: ... here. > >>> * features/arm-with-vfpv3.xml: Move to ... > >>> * features/arm/arm-with-vfpv3.xml: ... here. > >>> * features/arm-with-vfpv3.c: Move to ... > >>> * features/arm/arm-with-vfpv3.c: ... here. > >>> * features/Makefile: Use new paths to refer ARM files. > >>> * arm-tdep.c: Use new paths to include files. > >> > >> It seems like we have duplicate "arm" in some of the names now, it > >> might be a good cleanup to rename, e.g.: > >> > >> features/arm/arm-vfpv3.xml -> features/arm/vfpv3.xml > >> > > > > Thanks for comments. But files in folder i386 and rs6000 are same as mi= ne. > Maybe there are reasons to do so. > > > > For example: > > > > i386/ > > i386/i386-mmx.c > > i386/32bit-avx512.xml > > i386/x32-avx512.xml > > i386/x32-avx512-linux.c > > i386/32bit-sse.xml > > i386/32bit-mpx.xml > > i386/i386-avx-linux.xml > > i386/i386-mpx.c > > i386/i386-mpx-linux.xml > > i386/x32-core.xml > > i386/64bit-core.xml > > i386/i386.xml > > > > ./rs6000/powerpc-isa205-altivec64l.xml > > ./rs6000/powerpc-e500l.c > > ./rs6000/powerpc-altivec64l.c > > ./rs6000/powerpc-603.xml > > ./rs6000/powerpc-602.xml > > ./rs6000/power64-core.xml > > ./rs6000/powerpc-64.c > > ./rs6000/powerpc-altivec64.c > > ./rs6000/powerpc-505.xml > > > > BR, > > Terry >=20 > I think one of the reasons for having duplication there is that nobody > commented about it, like Will. >=20 > I'd go for the cleaner names without the duplication. The duplication cer= tainly > doesn't add anything to it. >=20 Hi Luis and Will, Thanks both of you. This clears my concerns. I will update this per your co= mments. BR, Terry