From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25615 invoked by alias); 23 Dec 2012 21:58:16 -0000 Received: (qmail 25607 invoked by uid 22791); 23 Dec 2012 21:58:15 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_20,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 23 Dec 2012 21:58:10 +0000 Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBNLvoHR047213 ; Sun, 23 Dec 2012 22:57:51 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms11.u-strasbg.fr [130.79.204.111]) by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBNLvnV4026113 ; Sun, 23 Dec 2012 22:57:49 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBNLvlwK001870 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Sun, 23 Dec 2012 22:57:48 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Eli Zaretskii'" Cc: References: <001201cde13f$af3ad4b0$0db07e10$%muller@ics-cnrs.unistra.fr> <837go8pnxn.fsf@gnu.org> In-Reply-To: <837go8pnxn.fsf@gnu.org> Subject: RE: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if statement Date: Sun, 23 Dec 2012 21:58:00 -0000 Message-ID: <001801cde158$8b8ba990$a2a2fcb0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00793.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Eli Zaretskii > Envoy=E9=A0: dimanche 23 d=E9cembre 2012 20:29 > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if > statement >=20 > > From: "Pierre Muller" > > Date: Sun, 23 Dec 2012 19:59:49 +0100 > > > > Looks almost obvious, but > > as it's the first of that kind, > > I thought I will send it as RFA nonetheless... > > > > Can similar changes be committed as obvious? > > They usually require some formatting changes, > > but generated behavior should not change. > > > > > > Pierre Muller > > as ARI maintainer > > > > > > 2012-12-20 Pierre Muller > > > > ARI fixes: Assignment within if rule. > > * cli/cli-cmds.c (shell_escape): Do not set variable value inside > > if statement. > > (edit_command): Likewise. >=20 > Since when is that bad C, so much so that we would need to enforce it? Eli, as you know,=20 I am not a C specialist at all... But I didn't invent that rule either. This rule part of gdb_ari.sh since it's introduction in CVS ss repository back in 2002. It's probably now your chance to challenge this rule... I would tend to agree that an assignment should be a statement on it's=20 own, but you could rightly consider this as a 'pascal' language preference! Pierre Muller both ARI and pascal language support maintainer!