From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8507 invoked by alias); 18 Dec 2012 08:35:54 -0000 Received: (qmail 8401 invoked by uid 22791); 18 Dec 2012 08:35:52 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 08:35:43 +0000 Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBI8ZfCD019380 for ; Tue, 18 Dec 2012 09:35:41 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms15.u-strasbg.fr [130.79.204.115]) by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBI8Ze6O029973 for ; Tue, 18 Dec 2012 09:35:41 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBI8Ze9f023971 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Tue, 18 Dec 2012 09:35:40 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Subject: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header. Date: Tue, 18 Dec 2012 08:35:00 -0000 Message-ID: <001801cddcfa$a93cef10$fbb6cd30$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00621.txt.bz2 This is both a RFA and a question about: should this be considered as an obvious fix? i.e. shouldn't all functions declared in headers have the extern modifier? Is this mandatory? It doesn't see to change anything in practice, but to me, it seems like good practice... ... but remember that my C programming knowledge is weak... Pierre Muller GDB pascal language maintainer 2012-12-18 Pierre Muller * ui-file.h (tee_file_new): Add extern modifier in header declaration. Index: ui-file.h =================================================================== RCS file: /cvs/src/src/gdb/ui-file.h,v retrieving revision 1.19 diff -u -p -r1.19 ui-file.h --- ui-file.h 18 Dec 2012 07:01:58 -0000 1.19 +++ ui-file.h 18 Dec 2012 08:31:00 -0000 @@ -135,7 +135,7 @@ extern struct ui_file *gdb_fopen (char * /* Create a file which writes to both ONE and TWO. CLOSE_ONE and CLOSE_TWO indicate whether the original files should be closed when the new file is closed. */ -struct ui_file *tee_file_new (struct ui_file *one, +extern struct ui_file *tee_file_new (struct ui_file *one, int close_one, struct ui_file *two, int close_two);