From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6815 invoked by alias); 21 Apr 2010 07:40:02 -0000 Received: (qmail 6795 invoked by uid 22791); 21 Apr 2010 07:40:00 -0000 X-SWARE-Spam-Status: No, hits=-0.5 required=5.0 tests=BAYES_05,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 07:39:55 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3L7dGww026371 ; Wed, 21 Apr 2010 09:39:16 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o3L7dFEn008281 ; Wed, 21 Apr 2010 09:39:15 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o3L7dEdJ015871 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 21 Apr 2010 09:39:15 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Cc: "'Joel Brobecker'" References: <20100421015425.GA10145@sourceware.org> In-Reply-To: <20100421015425.GA10145@sourceware.org> Subject: Explanation: New ARI warning Wed Apr 21 01:54:25 UTC 2010 Date: Wed, 21 Apr 2010 07:40:00 -0000 Message-ID: <001801cae125$cac33230$60499690$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00671.txt.bz2 Just to explain this email again: This is an automatic email generated by the=20 script update-web-ari that regenerates every night the ARI page. http://sourceware.org/gdb/current/ari/ Recently,=20 http://sourceware.org/ml/gdb-patches/2010-04/msg00149.html Tom agreed that we should try to send these email to gdb-patches directly. I committed this change to update-web-ari=20 in revision 1.148 date 2010/04/08. Since that date, this is the first email. Let me try to explain its content. > Objet=A0: New ARI warning Wed Apr 21 01:54:25 UTC 2010 This title indicates that the script believes that a recent change to either ARI handling in the ss directory or in the sources of GDB repository generated an additional ARI warning. Reminder: ARI stands for Awk Regression Index The name is probably due to the fact that it is mainly a awk language script meant to list a series of problems in the GDB sources. See the link above. > 266,267d265 > < gdb/defs.h:119: code: long long: Do not use 'long long', instead use > LONGEST > gdb/defs.h:119:#define LONGEST long long > < gdb/defs.h:120: code: long long: Do not use 'long long', instead use > LONGEST > gdb/defs.h:120:#define ULONGEST unsigned long long These two lines by themselves would not have generated an email to gdb-patches, because these correspond to two warnings that disappeared. The reason of this is that I change gdb_ari.sh yesterday. ---------------------------- revision 1.102 date: 2010/04/20 09:39:21; author: muller; state: Exp; lines: +2 -0 * Allow two "long long" in defs.h ---------------------------- This is because defs.h has two occurrences of "long long" that are necessary, and as such should not generate a warning. > 1072a1071 > > gdb/procfs.c:4090: code: sprintf: Do not use sprintf, instead use > xstrprintf > gdb/procfs.c:4090: sprintf (name, ', pi->pid, map->pr_mapname); > 1100d1098 > < gdb/procfs.c:5659: code: sprintf: Do not use sprintf, instead use > xstrprintf > gdb/procfs.c:5659: sprintf (name, ', pi->pid, map->pr_mapname); This is the part that triggered the email to gdb-patches In the series of patches committed by Joel tonight, he added some uses of sprint function,=20 which is banned by those ARI rules. Note that today procfs.c has 25 uses of sprint instead of 23 yesterday. With this new automated email generation, people committing patches that increase the number of ARI warnings will at least get some information about it. Any simple patch that removes those warnings should probably be considered as obvious. Pierre Muller as ARI maintainer.