From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21738 invoked by alias); 8 Mar 2010 16:55:41 -0000 Received: (qmail 21720 invoked by uid 22791); 8 Mar 2010 16:55:41 -0000 X-SWARE-Spam-Status: No, hits=0.8 required=5.0 tests=AWL,BAYES_50,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Mar 2010 16:55:36 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id o28GtWbA042316 for ; Mon, 8 Mar 2010 17:55:33 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o28GtW5V078201 for ; Mon, 8 Mar 2010 17:55:32 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o28GtWLB057859 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Mon, 8 Mar 2010 17:55:32 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Subject: [PATCH] avoid GDB crash on inspection of pascal arrays Date: Mon, 08 Mar 2010 16:55:00 -0000 Message-ID: <001801cabee0$31499ca0$93dcd5e0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00314.txt.bz2 The is_pascal_string_type function in p-lang.c could sometimes be called with an type parameter being NULL. This caused crashes in the Free Pascal IDE, that I finally debugged recently. Checked in as pascal language maintainer, Pierre Muller ChangeLog entry: 2020-03-08 Pierre Muller * p-lang.c (is_pascal_string_type): Check that TYPE arg is non NULL. Index: p-lang.c =================================================================== RCS file: /cvs/src/src/gdb/p-lang.c,v retrieving revision 1.50 diff -u -p -r1.50 p-lang.c --- p-lang.c 14 Jan 2010 08:03:36 -0000 1.50 +++ p-lang.c 8 Mar 2010 16:49:20 -0000 @@ -101,7 +101,7 @@ is_pascal_string_type (struct type *type struct type **char_type, char **arrayname) { - if (TYPE_CODE (type) == TYPE_CODE_STRUCT) + if ((type != NULL) && (TYPE_CODE (type) == TYPE_CODE_STRUCT)) { /* Old Borland type pascal strings from Free Pascal Compiler. */ /* Two fields: length and st. */ 2010-03-08 Jan Kratochvil Hui Zhu