From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFA] testsuite: avoid compilation error on cygwin/mingw if -nostdlib option is used.
Date: Thu, 01 Oct 2009 22:36:00 -0000 [thread overview]
Message-ID: <001801ca42e7$94c15fe0$be441fa0$@u-strasbg.fr> (raw)
To get useful output of the testsuite
for cygwin/mingw/djgpp, we need to force
the compiled programs in the testsuite to
act as it they were on a terminal,
which usually results into disabling buffering
for stdout and stderr.
This does not work for cygwin,
and thus we added set_unbuffered_mode.c
code.
This works almost always, unless -nostdlib
option is given at link time, as in that case
setvbuf function call will not be resolved.
The patch below disables adding the set_unbuffered_mode
object if -nostdlib option is given.
Pierre Muller
Pascal language support maintainer for GDB
2009-10-02 Pierre Muller <muller@ics.u-strasbg.fr>
* lib/gdb.exp (gdb_compile): Avoid adding
gdb_saved_unbuffered_mode_obj if -nostdlib option is used.
Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.119
diff -u -p -r1.119 gdb.exp
--- lib/gdb.exp 13 Jul 2009 19:24:18 -0000 1.119
+++ lib/gdb.exp 1 Oct 2009 21:56:14 -0000
@@ -1802,6 +1854,11 @@ proc gdb_compile {source dest type optio
# which is time consuming, especially if we're remote
# host testing.
#
+ set add_unbuffered_object 1;
+ if {[lsearch -regexp $options ".*-nostdlib.*"] >= 0 } {
+ verbose "No set_unbuffered_mode for -nostdlib option";
+ set add_unbuffered_object 0;
+ }
if { $gdb_saved_set_unbuffered_mode_obj == "" } {
verbose "compiling gdb_saved_set_unbuffered_obj"
set unbuf_src ${srcdir}/lib/set_unbuffered_mode.c
@@ -1824,7 +1881,9 @@ proc gdb_compile {source dest type optio
# reverse link order. In that case, we can use ldflags to
# avoid copying the object file to the host multiple
# times.
- lappend options "ldflags=$gdb_saved_set_unbuffered_mode_obj"
+ if { $add_unbuffered_object == 1 } {
+ lappend options "ldflags=$gdb_saved_set_unbuffered_mode_obj"
+ }
}
}
next reply other threads:[~2009-10-01 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 22:36 Pierre Muller [this message]
2009-10-01 23:29 ` Pedro Alves
2009-10-02 7:15 ` [RFA-v2] " Pierre Muller
2009-10-02 16:58 ` Pedro Alves
2009-10-02 21:30 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001801ca42e7$94c15fe0$be441fa0$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox