[RFC] Insight build problem: was [06/15] Per-breakpoint architecture support

["Pierre Muller" <muller@ics.u-strasbg.fr>]

  Ulrich,

  your patch made a unlogged change to set_raw_breakpoint:
> ===================================================================
> --- gdb-head.orig/gdb/breakpoint.c
> +++ gdb-head/gdb/breakpoint.c
> @@ -20,6 +20,7 @@
>     along with this program.  If not, see
> <http://www.gnu.org/licenses/>.  */
> 
>  #include "defs.h"
> +#include "arch-utils.h"
>  #include <ctype.h>
>  #include "hashtab.h"
>  #include "symtab.h"
> @@ -104,13 +105,16 @@ static void break_command_1 (char *, int
> 
>  static void mention (struct breakpoint *);
> 
> -struct breakpoint *set_raw_breakpoint (struct symtab_and_line, enum
> bptype);
> +static struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch,
> +					      struct symtab_and_line,
> +					      enum bptype);

   This seems harmless as the function is not in any header, but
this function is used in gdbtk sources.
   I don't really know if gdbtk failures qualify for patches
as such, but it seems to me that it would be difficult to 
change the gdbtk-bp.c code to avoid using this function.
  
  Is this failure a sufficient reason to accept this patch 
or should we go another route (maybe add set_raw_breakpoint
to breakpoint.h header ?).



Pierre Muller
Pascal language support maintainer for GDB



2009-07-07  Pierre Muller  <muller@ics.u-strasbg.fr>

	* breakpoint.c (set_raw_breakpoint): Remove static modifier.

	

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.412
diff -u -p -r1.412 breakpoint.c
--- breakpoint.c	2 Jul 2009 17:21:05 -0000	1.412
+++ breakpoint.c	7 Jul 2009 12:45:41 -0000
@@ -105,7 +105,8 @@ static void break_command_1 (char *, int
 
 static void mention (struct breakpoint *);
 
-static struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch,
+/* This function is used in gdbtk sources and thus can not be made static.
*/
+struct breakpoint *set_raw_breakpoint (struct gdbarch *gdbarch,
 					      struct symtab_and_line,
 					      enum bptype);
 
@@ -4396,8 +4397,9 @@ static void free_bp_location (struct bp_
 
 /* Helper to set_raw_breakpoint below.  Creates a breakpoint
    that has type BPTYPE and has no locations as yet.  */
+/* This function is used in gdbtk sources and thus can not be made static.
*/
 
-static struct breakpoint *
+struct breakpoint *
 set_raw_breakpoint_without_location (struct gdbarch *gdbarch,
 				     enum bptype bptype)
 {
@@ -4480,7 +4482,7 @@ get_sal_arch (struct symtab_and_line sal
    prior to completing the initialization of the breakpoint.  If this
    should happen, a bogus breakpoint will be left on the chain.  */
 
-static struct breakpoint *
+struct breakpoint *
 set_raw_breakpoint (struct gdbarch *gdbarch,
 		    struct symtab_and_line sal, enum bptype bptype)
 {