From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24014 invoked by alias); 7 Sep 2007 10:12:18 -0000 Received: (qmail 24004 invoked by uid 22791); 7 Sep 2007 10:12:17 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Sep 2007 10:12:09 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with ESMTP id 2269E18701A for ; Fri, 7 Sep 2007 12:17:19 +0200 (CEST) From: "Pierre Muller" To: Subject: [PING][Patch RFC] ARI changes for p-valprint.c Date: Fri, 07 Sep 2007 10:12:00 -0000 Message-ID: <001601c7f137$937f3070$ba7d9150$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00080.txt.bz2 <> I got no comments on this email :( <> Should I check it in nevertheless? <>=20 <> Original message starts here: I looked at the ARI failures of pascal specific files and tried to fix them. Here is a first bunch related to the input file p-valprint.c: it fixes three deprecated and four operators at end of line problems detected in ARI. I could commit these as pascal maintainer, but I would like to have feedback,=20 especially about how to phrase the ChangeLog entry, I put a minimal here,=20 but would like to know if more details are needed. Pierre Muller Charg=E9 de recherches Institut Charles Sadron 6, rue Boussingault F 67083 Strasbourg Cedex T=E9l. : +(33)3-88-41-40-07 Email : pierre.muller@ics.u-strasbg.fr <> I updated the diff to the current cvs. ChangeLog entry 2007-09-07 Pierre Muller * p-valprint.c: Fix 7 ARI reported problems. $ cvs diff -up p-valprint.c Index: p-valprint.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/p-valprint.c,v retrieving revision 1.50 diff -u -p -r1.50 p-valprint.c --- p-valprint.c 23 Aug 2007 18:08:36 -0000 1.50 +++ p-valprint.c 7 Sep 2007 10:04:47 -0000 @@ -85,8 +85,8 @@ pascal_val_print (struct type *type, con print_spaces_filtered (2 + 2 * recurse, stream); } /* For an array of chars, print with string syntax. */ - if (eltlen =3D=3D 1 && - ((TYPE_CODE (elttype) =3D=3D TYPE_CODE_INT) + if (eltlen =3D=3D 1 + && ((TYPE_CODE (elttype) =3D=3D TYPE_CODE_INT) || ((current_language->la_language =3D=3D language_m2) && (TYPE_CODE (elttype) =3D=3D TYPE_CODE_CHAR))) && (format =3D=3D 0 || format =3D=3D 's')) @@ -164,7 +164,7 @@ pascal_val_print (struct type *type, con if (addressprint && format !=3D 's') { - deprecated_print_address_numeric (addr, 1, stream); + fputs_filtered (paddress(addr), stream); } /* For a pointer to char or unsigned char, also print the string @@ -217,7 +217,7 @@ pascal_val_print (struct type *type, con int is_this_fld; if (msymbol !=3D NULL) - wsym =3D lookup_symbol (DEPRECATED_SYMBOL_NAME (msymbol= ), block, + wsym =3D lookup_symbol ((msymbol)->ginfo.name, block, VAR_DOMAIN, &is_this_fld, NULL); if (wsym) @@ -252,11 +252,9 @@ pascal_val_print (struct type *type, con { fprintf_filtered (stream, "@"); /* Extract the address, assume that it is unsigned. */ - deprecated_print_address_numeric - (extract_unsigned_integer (valaddr + embedded_offset, - gdbarch_ptr_bit (current_gdbarch) - / HOST_CHAR_BIT), - 1, stream); + fputs_filtered (paddress( + extract_unsigned_integer (valaddr + embedded_offset, + gdbarch_ptr_bit (current_gdbarch) / HOST_CHAR_BIT)), stream); if (deref_ref) fputs_filtered (": ", stream); } @@ -530,14 +528,14 @@ pascal_value_print (struct value *val, s Object pascal: if it is a member pointer, we will take care of that when we print it. */ - if (TYPE_CODE (type) =3D=3D TYPE_CODE_PTR || - TYPE_CODE (type) =3D=3D TYPE_CODE_REF) + if (TYPE_CODE (type) =3D=3D TYPE_CODE_PTR + || TYPE_CODE (type) =3D=3D TYPE_CODE_REF) { /* Hack: remove (char *) for char strings. Their type is indicated by the quoted string anyway. */ - if (TYPE_CODE (type) =3D=3D TYPE_CODE_PTR && - TYPE_NAME (type) =3D=3D NULL && - TYPE_NAME (TYPE_TARGET_TYPE (type)) !=3D NULL + if (TYPE_CODE (type) =3D=3D TYPE_CODE_PTR + && TYPE_NAME (type) =3D=3D NULL + && TYPE_NAME (TYPE_TARGET_TYPE (type)) !=3D NULL && strcmp (TYPE_NAME (TYPE_TARGET_TYPE (type)), "char") =3D=3D 0) { /* Print nothing */