From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21097 invoked by alias); 11 Dec 2012 13:01:43 -0000 Received: (qmail 21084 invoked by uid 22791); 11 Dec 2012 13:01:41 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT,TW_BT,TW_DB X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Dec 2012 13:01:34 +0000 Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBBD1WM2090370 for ; Tue, 11 Dec 2012 14:01:32 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms13.u-strasbg.fr [130.79.204.113]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBBD1WQ6028129 for ; Tue, 11 Dec 2012 14:01:32 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBBD1Wme022953 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Tue, 11 Dec 2012 14:01:32 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Subject: [RFA] Make contrib/ari/gdb_find.sh script more configurable Date: Tue, 11 Dec 2012 13:01:00 -0000 Message-ID: <001501cdd79f$a5a94c00$f0fbe400$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00320.txt.bz2 As we were talking about adding gdbserver to the list of directories that should also be inspected by Awk regression scripts, I propose hereby a patch allowing to include directory gdbtk, gdbserver or gnulib to the list of inspected directories by simply exporting a variable named check_XXX_dir before running the scripts. Does this look OK to you? Is the ChangeLog entry OK? Pierre Muller as ARI maintainer 2012-12-11 Pierre Muller * contrib/ari/gdb_find.sh (add_pruned_directory): New function. (check_gdbtk_dir, check_gdbserver_dir, check_gnulib_dir): Add test for presence of variables to conditionally prune corresponding directory. Index: contrib/ari/gdb_find.sh =================================================================== RCS file: /cvs/src/src/gdb/contrib/ari/gdb_find.sh,v retrieving revision 1.5 diff -u -p -r1.5 gdb_find.sh --- contrib/ari/gdb_find.sh 7 Dec 2012 02:57:49 -0000 1.5 +++ contrib/ari/gdb_find.sh 11 Dec 2012 12:54:56 -0000 @@ -29,11 +29,38 @@ LC_ALL=C ; export LC_ALL # A find that prunes files that GDB users shouldn't be interested in. # Use sort to order files alphabetically. -find "$@" \ - -name testsuite -prune -o \ - -name gdbserver -prune -o \ - -name gdbtk -prune -o \ - -name gnulib -prune -o \ +find_args= + +add_pruned_directory () +{ + pruned_dir=$1 + if [ ! -z "$verbose" ] ; then + echo "Adding directory \"$pruned_dir\" to list of pruned directories" + fi + findargs="$findargs -name $pruned_dir -prune -o " +} + +# Setting environment variables +# check_gdbtk_dir, check_gdbserver_dir and check_gnulib_dir +# to non empty will trigger the addition of the files contained +# in directory gdbtk and gdbserver respectively. +# By default, these directory are not listed. + +if [ -z "$check_gdbtk_dir" ] ; then + add_pruned_directory gdbtk +fi + +if [ -z "$check_gdbserver_dir" ] ; then + add_pruned_directory gdbserver +fi + +if [ -z "$check_gnulib_dir" ] ; then + add_pruned_directory gnulib +fi + +add_pruned_directory testsuite + +find "$@" $findargs \ -name '*-stub.c' -prune -o \ -name '*-exp.c' -prune -o \ -name ada-lex.c -prune -o \