From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21780 invoked by alias); 4 May 2010 06:34:47 -0000 Received: (qmail 21769 invoked by uid 22791); 4 May 2010 06:34:46 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 May 2010 06:34:41 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o446YN4c084188 ; Tue, 4 May 2010 08:34:24 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o446YMWf029223 ; Tue, 4 May 2010 08:34:22 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o446YKJZ012490 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 4 May 2010 08:34:21 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Jan Kratochvil'" , Cc: "'Pedro Alves'" , , "'Mark Kettenis'" References: <20100430181605.GA19190@host0.dyn.jankratochvil.net> <20100502213636.GA21869@host0.dyn.jankratochvil.net> <20100502231941.GA27802@host0.dyn.jankratochvil.net> <201005030041.55468.pedro@codesourcery.com> <20100502235257.GA29708@host0.dyn.jankratochvil.net> <000f01caea90$b99a0730$2cce1590$@muller@ics-cnrs.unistra.fr> <20100503074356.GA14569@host0.dyn.jankratochvil.net> In-Reply-To: <20100503074356.GA14569@host0.dyn.jankratochvil.net> Subject: RE: [patch] ATTR_NORETURN -> ATTRIBUTE_NORETURN unification [Re: [patch] ATTR_* -> ATTRIBUTE_* unification] Date: Tue, 04 May 2010 06:34:00 -0000 Message-ID: <001501caeb53$d8c3bd40$8a4b37c0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00061.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Jan Kratochvil > Envoy=E9=A0: Monday, May 03, 2010 9:44 AM > =C0=A0: Pierre Muller > Cc=A0: 'Pedro Alves'; gdb-patches@sourceware.org; 'Mark Kettenis' > Objet=A0: Re: [patch] ATTR_NORETURN -> ATTRIBUTE_NORETURN unification > [Re: [patch] ATTR_* -> ATTRIBUTE_* unification] >=20 > On Mon, 03 May 2010 09:17:42 +0200, Pierre Muller wrote: > > Should I add a rule to gdb_ari.sh > > suggesting to use ATTRIBUTE_NORETURN > > instead of NORETURN or ATTR_NORETURN? > > > > Should I do the same for ATTRIBUTE_PRINTF? >=20 > Any of an inadvertent use of NORETURN, ATTR_NORETURN or ATTR_FORMAT now > causes > a compilation error as definitions of these symbols have been removed > now. > Therefore I believe ARI is not needed in this case. =20=20 But they could still be defined in some=20 headers of a particular system. If someone uses such a macro for a native file, we will get no feedback... Tom, what did you mean by poison these identifiers? Something like #undef NORETURN #define NORETURN "Anything that will for sure create a compilation error" I see nothing like this in gdb/defs.h=20 Is this something we should start? =20=20 Pierre