From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <pedro@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] [2/4] Mingw64 gdbserver support
Date: Tue, 20 Apr 2010 06:10:00 -0000 [thread overview]
Message-ID: <001501cae050$1feea720$5fcbf560$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <201004200022.31807.pedro@codesourcery.com>
It appears that I missed two issues raised by
Pedro in my commit of part 2.
This patch resolves those.
With my apologies,
Pierre
2010-04-20 Pierre Muller <muller@ics.u-strasbg.fr>
* win32-i386-low.c: Use __x86_64__ macro instead of __x86_64 to
be consistent with other sources of this directory.
(init_registers_amd64): Correct name of source file of this function
in the comment.
Index: win32-i386-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/win32-i386-low.c,v
retrieving revision 1.19
diff -u -p -r1.19 win32-i386-low.c
--- win32-i386-low.c 20 Apr 2010 00:17:05 -0000 1.19
+++ win32-i386-low.c 20 Apr 2010 06:03:48 -0000
@@ -28,8 +28,8 @@
#define FLAG_TRACE_BIT 0x100
-#ifdef __x86_64
-/* Defined in auto-generated file reg-i386.c. */
+#ifdef __x86_64__
+/* Defined in auto-generated file reg-amd64.c. */
void init_registers_amd64 (void);
#else
/* Defined in auto-generated file reg-i386.c. */
@@ -223,7 +223,7 @@ i386_single_step (win32_thread_info *th)
th->context.EFlags |= FLAG_TRACE_BIT;
}
-#ifndef __x86_64
+#ifndef __x86_64__
/* An array of offset mappings into a Win32 Context structure.
This is a one-to-one mapping which is indexed by gdb's register
@@ -280,7 +280,7 @@ static const int mappings[] = {
};
#undef context_offset
-#else /* __x86_64 */
+#else /* __x86_64__ */
#define context_offset(x) (offsetof (CONTEXT, x))
static const int mappings[] =
@@ -347,7 +347,7 @@ static const int mappings[] =
};
#undef context_offset
-#endif /* __x86_64 */
+#endif /* __x86_64__ */
/* Fetch register from gdbserver regcache data. */
static void
@@ -386,7 +386,7 @@ static const unsigned char i386_win32_br
static void
init_windows_x86 (void)
{
-#ifdef __x86_64
+#ifdef __x86_64__
init_registers_amd64 ();
#else
init_registers_i386 ();
next prev parent reply other threads:[~2010-04-20 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 22:57 Pierre Muller
2010-04-19 23:22 ` Pedro Alves
2010-04-20 6:10 ` Pierre Muller [this message]
2010-04-20 9:52 ` Pedro Alves
2010-04-20 9:59 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001501cae050$1feea720$5fcbf560$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox