From: Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/6] gdb/infcmd: remove the unused parameter 'args' in 'attach_post_wait'
Date: Wed, 21 Apr 2021 14:57:26 +0200 [thread overview]
Message-ID: <0013ebfdeb103a5142264bf02fc7abc4628a572a.1619009681.git.tankut.baris.aktemur@intel.com> (raw)
In-Reply-To: <cover.1619009681.git.tankut.baris.aktemur@intel.com>
In-Reply-To: <cover.1619009681.git.tankut.baris.aktemur@intel.com>
gdb/ChangeLog:
2021-04-21 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* infcmd.c (attach_post_wait): Remove the unused parameter 'args'.
Update the references below.
(struct attach_command_continuation_args)
(attach_command_continuation)
(attach_command_continuation_free_args)
(attach_command)
(notice_new_inferior): Update to remove the reference to 'args'.
---
gdb/infcmd.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 60f25d24686..f89eb7beb03 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -2471,7 +2471,7 @@ enum attach_post_wait_mode
should be running. Else if ATTACH, */
static void
-attach_post_wait (const char *args, int from_tty, enum attach_post_wait_mode mode)
+attach_post_wait (int from_tty, enum attach_post_wait_mode mode)
{
struct inferior *inferior;
@@ -2542,7 +2542,6 @@ attach_post_wait (const char *args, int from_tty, enum attach_post_wait_mode mod
struct attach_command_continuation_args
{
- char *args;
int from_tty;
enum attach_post_wait_mode mode;
};
@@ -2556,7 +2555,7 @@ attach_command_continuation (void *args, int err)
if (err)
return;
- attach_post_wait (a->args, a->from_tty, a->mode);
+ attach_post_wait (a->from_tty, a->mode);
}
static void
@@ -2565,7 +2564,6 @@ attach_command_continuation_free_args (void *args)
struct attach_command_continuation_args *a
= (struct attach_command_continuation_args *) args;
- xfree (a->args);
xfree (a);
}
@@ -2677,7 +2675,6 @@ attach_command (const char *args, int from_tty)
/* Wait for stop. */
a = XNEW (struct attach_command_continuation_args);
- a->args = xstrdup (args);
a->from_tty = from_tty;
a->mode = mode;
add_inferior_continuation (attach_command_continuation, a,
@@ -2692,7 +2689,7 @@ attach_command (const char *args, int from_tty)
return;
}
else
- attach_post_wait (args, from_tty, mode);
+ attach_post_wait (from_tty, mode);
disable_commit_resumed.reset_and_commit ();
}
@@ -2737,7 +2734,6 @@ notice_new_inferior (thread_info *thr, int leave_running, int from_tty)
/* Wait for stop before proceeding. */
a = XNEW (struct attach_command_continuation_args);
- a->args = xstrdup ("");
a->from_tty = from_tty;
a->mode = mode;
add_inferior_continuation (attach_command_continuation, a,
@@ -2746,7 +2742,7 @@ notice_new_inferior (thread_info *thr, int leave_running, int from_tty)
return;
}
- attach_post_wait ("" /* args */, from_tty, mode);
+ attach_post_wait (from_tty, mode);
}
/*
--
2.17.1
next prev parent reply other threads:[~2021-04-21 12:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 12:57 [PATCH 0/6] Refactoring around inferior continuations Tankut Baris Aktemur via Gdb-patches
2021-04-21 12:57 ` Tankut Baris Aktemur via Gdb-patches [this message]
2021-04-21 19:24 ` [PATCH 1/6] gdb/infcmd: remove the unused parameter 'args' in 'attach_post_wait' Tom Tromey
2021-04-21 19:32 ` Simon Marchi via Gdb-patches
2021-04-21 19:47 ` Tom Tromey
2021-04-22 5:57 ` Aktemur, Tankut Baris via Gdb-patches
2021-04-21 12:57 ` [PATCH 2/6] gdb/infcmd: update the comment for 'attach_post_wait' Tankut Baris Aktemur via Gdb-patches
2021-04-21 19:25 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 3/6] gdb/continuations: remove the 'err' from 'do_all_inferior_continuations' Tankut Baris Aktemur via Gdb-patches
2021-04-21 19:29 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 4/6] gdb/continuations: do minor cleanup Tankut Baris Aktemur via Gdb-patches
2021-04-21 19:31 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 5/6] gdb/continuations: use lambdas instead of function pointers Tankut Baris Aktemur via Gdb-patches
2021-04-21 19:43 ` Tom Tromey
2021-04-22 7:49 ` Aktemur, Tankut Baris via Gdb-patches
2021-04-22 12:50 ` Tom Tromey
2021-04-22 14:07 ` Aktemur, Tankut Baris via Gdb-patches
2021-04-22 14:12 ` Tom Tromey
2021-04-21 12:57 ` [PATCH 6/6] gdb/continuations: turn continuation functions into inferior methods Tankut Baris Aktemur via Gdb-patches
2021-04-21 19:46 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0013ebfdeb103a5142264bf02fc7abc4628a572a.1619009681.git.tankut.baris.aktemur@intel.com \
--to=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox