From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50078-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17851 invoked by alias); 3 Aug 2007 14:43:05 -0000
Received: (qmail 17843 invoked by uid 22791); 3 Aug 2007 14:43:03 -0000
X-Spam-Check-By: sourceware.org
Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Aug 2007 14:43:01 +0000
Received: from snyder (209-204-172-156.dsl.dynamic.sonic.net [209.204.172.156]) 	by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with SMTP id l73Egn6X031367; 	Fri, 3 Aug 2007 07:42:49 -0700
Message-ID: <001301c7d5db$d5702880$677ba8c0@sonic.net>
Reply-To: "Michael Snyder" <msnyder@sonic.net>
From: "Michael Snyder" <msnyder@sonic.net>
To: "Eli Zaretskii" <eliz@gnu.org>
Cc: <drow@false.org>, <gdb-patches@sourceware.org>
References: <10431.12.7.175.2.1186103684.squirrel@webmail.sonic.net> <20070803013005.GA22901@caradoc.them.org> <006901c7d587$db360400$677ba8c0@sonic.net> <uy7gsbxzg.fsf@gnu.org>
Subject: Re: [PATCH] symfile.c, find_separate_debug_file
Date: Fri, 03 Aug 2007 14:43:00 -0000
X-Mailer: Microsoft Outlook Express 6.00.2800.1437
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-08/txt/msg00051.txt.bz2


----- Original Message ----- 
From: "Eli Zaretskii" <eliz@gnu.org>
To: "Michael Snyder" <msnyder@sonic.net>
Cc: <drow@false.org>; <gdb-patches@sourceware.org>
Sent: Friday, August 03, 2007 5:31 AM
Subject: Re: [PATCH] symfile.c, find_separate_debug_file


> > From: "Michael Snyder" <msnyder@sonic.net>
> > Cc: <gdb-patches@sourceware.org>
> > Date: Thu, 2 Aug 2007 21:36:27 -0700
> >
> > > > * symfile.c (find_separate_debug_file): While consing up a path,
> > > > don't stick in an extra DIR_SEPARATOR.
> > >
> > > That's right, use DIR_SEPARATOR :-)  IS_DIR_SEPARATOR in this case, I
> > > think?
> >
> > The existing code doesn't use it.
>
> Correction: the existing code appends "/" unconditionally, which is
> fine, since both Posix and non-Posix platforms support forward slashes
> in file names.
>
> But Daniel didn't mean that: he meant to use IS_DIR_SEPARATOR instead
> of literal comparison to '/' alone.  The existing code didn't test
> anything, so it didn't have to cope with this issue.

Yes, I understood exactly what Daniel meant.  I was saying,
the existing code uses the literal '/' instead of the symbolic
DIR_SEPARATOR.

I offered to have another go at the code and clean up the literals,
but as a separate patch to this one.