From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29730 invoked by alias); 9 Jan 2015 16:16:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29564 invoked by uid 89); 9 Jan 2015 16:15:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Jan 2015 16:15:56 +0000 Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id E37E314147F; Fri, 9 Jan 2015 17:15:51 +0100 (CET) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id D3A211413DF; Fri, 9 Jan 2015 17:15:51 +0100 (CET) Received: from lmr.u-strasbg.fr (lmr3.u-strasbg.fr [172.30.21.3]) by mr2.u-strasbg.fr (Postfix) with ESMTP id B082F1414B0; Fri, 9 Jan 2015 17:15:49 +0100 (CET) Received: from lmr.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 783D5BA; Fri, 9 Jan 2015 17:15:49 +0100 (CET) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by lmr3.u-strasbg.fr (Postfix) with ESMTPSA id 2F9F6D6; Fri, 9 Jan 2015 17:15:47 +0100 (CET) From: "Pierre Muller" To: "'Pedro Alves'" Cc: "'gdb-patches'" References: <54ae4586.01e3440a.7b06.fffff844SMTPIN_ADDED_BROKEN@mx.google.com> <54AE605A.8050308@redhat.com> <54ae7f9f.c323460a.36ed.ffffff30SMTPIN_ADDED_BROKEN@mx.google.com> <54AE8914.4010507@redhat.com> <54ae911b.85e3440a.1d96.5ffdSMTPIN_ADDED_BROKEN@mx.google.com> <54AFB2E5.5080307@redhat.com> In-Reply-To: <54AFB2E5.5080307@redhat.com> Subject: [RFA 0/3] Fix pascal behavior for class fields with testcase Date: Fri, 09 Jan 2015 16:16:00 -0000 Message-ID: <001201d02c27$87cbee20$9763ca60$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-01/txt/msg00220.txt.bz2 I finally started to try git format-patch. The three patch emails that will follow contain: 1) The fix in p-exp.y to cope correctly with this fields 2) New options for pascal compilation in the testsuite 3) A testcase for PR pascal/17815 I hope this is correct... but there are surely some formatting and name conventions that I do not follow correctly... Pierre Muller > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: vendredi 9 janvier 2015 11:52 > =C0=A0: Pierre Muller; 'gdb-patches' > Cc=A0: gpc@gnu.de > Objet=A0: Re: gdb-patches RFA: Fix pascal behavior for class fields >=20 > On 01/08/2015 02:15 PM, Pierre Muller wrote: > > For gpc mailing list: > > this email comes as a follow-up of this bug report > > https://sourceware.org/bugzilla/show_bug.cgi?id=3D17815 > > > > The start of the thread can be found at: > > https://sourceware.org/ml/gdb-patches/2015-01/msg00164.html > > > > Pedro asked: > >>>> How about adding this to the test suite? > >>> > >>> > >>> The whole testsuite/gdb.pascal is almost empty, > >>> I never invested time to develop it :( > >>> > >>> At the time I started it, GPC (the GNU pascal compiler) > >>> was still active, but development apparently > >>> stopped since quite some time. > >>> > >>> I am unable to install GPC, which means that I cannot test it. > >>> Would a testsuite that supports only Free Pascal be acceptable? > >> > >> Do you actually mean, whether it's ok for a new > >> test (not test suite) to go in untested on GPC? It certainly is. > >> Better test on FPC than nowhere. :-) > > That is indeed what I meant. > > > >> AFAICS, the tests themselves don't really care which compiler > >> is in use other than for marking xfails; you just call > >> gdb_compile_pascal, > >> and that works with either. That's my impression from quickly > >> skimming testsuite/lib/pascal.exp. > > > > The problem is that GPC and Free Pascal support several > > pascal 'dialects'. But this requires command line options. > > > > The -Mobjfpc option is required for Free Pascal compiler > > to understand class type definition, but is rejected in default mode. > > > > I expect GNU GPC to also reject class in 'normal' mode... > > Maybe someone on the gpc mailing list knows if classes are supported > > by GPC and if it requires a special compiler option. >=20 > I'd suggest adding support for a new option to > gdb_compile_pascal, like "objfpc", so you'd compile > the test with: >=20 > if {[gdb_compile_pascal ... executable [list debug objfpc]] !=3D "" } { > untested $testfile.exp > return -1 > } >=20 > You'd teach fpc_compile about the new option: >=20 > proc fpc_compile {source dest type options} { > ... > foreach i $options { > ... > } elseif { $i =3D=3D "objfpc" } { > append add_flags " -Mobjfpc" > } > ... > } >=20 >=20 > Someone that cares about testing with GNU GPC would then > do the equivalent to gpc_compile, if anything is necessary. > If gpc simply fails to compile the test, it's no biggie, > as gdb_compile_pascal returns false, and the test is > skipped with "untested". >=20 > There may be a more generic and common name for the mode, > like "obj-pascal" or something, but I wouldn't know. >=20 > Thanks, > Pedro Alves