From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15127 invoked by alias); 23 Dec 2012 19:00:06 -0000 Received: (qmail 14926 invoked by uid 22791); 23 Dec 2012 19:00:02 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 23 Dec 2012 18:59:54 +0000 Received: from md14.u-strasbg.fr (md14.u-strasbg.fr [130.79.200.249]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBNIxpis030545 for ; Sun, 23 Dec 2012 19:59:52 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms17.u-strasbg.fr [130.79.204.117]) by md14.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBNIxp7N024955 for ; Sun, 23 Dec 2012 19:59:51 +0100 Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qBNIxpGl028582 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Sun, 23 Dec 2012 19:59:51 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: Subject: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if statement Date: Sun, 23 Dec 2012 19:00:00 -0000 Message-ID: <001201cde13f$af3ad4b0$0db07e10$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00791.txt.bz2 Looks almost obvious, but as it's the first of that kind, I thought I will send it as RFA nonetheless... Can similar changes be committed as obvious? They usually require some formatting changes, but generated behavior should not change. Pierre Muller as ARI maintainer 2012-12-20 Pierre Muller ARI fixes: Assignment within if rule. * cli/cli-cmds.c (shell_escape): Do not set variable value inside if statement. (edit_command): Likewise. Index: src/gdb/cli/cli-cmds.c =================================================================== RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v retrieving revision 1.143 diff -u -p -r1.143 cli-cmds.c --- src/gdb/cli/cli-cmds.c 18 Dec 2012 19:27:35 -0000 1.143 +++ src/gdb/cli/cli-cmds.c 20 Dec 2012 16:10:27 -0000 @@ -724,11 +724,13 @@ shell_escape (char *arg, int from_tty) #else /* Can fork. */ int status, pid; - if ((pid = vfork ()) == 0) + pid = vfork (); + if (pid == 0) { const char *p, *user_shell; - if ((user_shell = (char *) getenv ("SHELL")) == NULL) + user_shell = (char *) getenv ("SHELL"); + if (user_shell == NULL) user_shell = "/bin/sh"; /* Get the name of the shell for arg0. */ @@ -837,7 +839,8 @@ edit_command (char *arg, int from_tty) error (_("No line number known for %s."), arg); } - if ((editor = (char *) getenv ("EDITOR")) == NULL) + editor = (char *) getenv ("EDITOR"); + if (editor == NULL) editor = "/bin/ex"; /* If we don't already know the full absolute file name of the