From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17110 invoked by alias); 28 May 2010 10:17:09 -0000 Received: (qmail 17100 invoked by uid 22791); 28 May 2010 10:17:09 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 May 2010 10:17:04 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o4SAH18i080100 for ; Fri, 28 May 2010 12:17:01 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o4SAH1fd087962 for ; Fri, 28 May 2010 12:17:01 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o4SAH1Gq097496 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Fri, 28 May 2010 12:17:01 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: References: <001901caf934$fd580460$f8080d20$@muller@ics-cnrs.unistra.fr> <20100525205241.GA5298@ednor.casa.cgf.cx> <000601cafca7$ead3af80$c07b0e80$@muller@ics-cnrs.unistra.fr> <20100526170712.GA32594@ednor.casa.cgf.cx> <001801cafd69$018b9a00$04a2ce00$@muller@ics-cnrs.unistra.fr> <001e01cafd6c$2a0c87c0$7e259740$@muller@ics-cnrs.unistra.fr> <20100527151730.GA483@ednor.casa.cgf.cx> In-Reply-To: <20100527151730.GA483@ednor.casa.cgf.cx> Subject: RE: [RFA] windows-nat.c: Copy console information for new console Date: Fri, 28 May 2010 15:28:00 -0000 Message-ID: <001201cafe4e$e885afa0$b9910ee0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00681.txt.bz2 > >> From Christopher Faylor > >> I actually thought fairly carefully about flags. If you have a > >> function > >> which controls console info, then the function should set the flags > >> appropriately to deal with the console info. > > > > > > As you prefer, > >here is a new version that also takes DWORD *flags as parameter. > > I also tried to explain a little bit better > >what the function tries to do. > > Thanks. Looks good. I forgot to say: Thanks for doing this. It > looks like > a nice improvement. Hi Christopher, does this mean that you want to test it a little bit more before you give some more detailed review or should I understand this as an approval? Pierre