From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1165 invoked by alias); 17 May 2010 21:46:16 -0000 Received: (qmail 1152 invoked by uid 22791); 17 May 2010 21:46:12 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 May 2010 21:46:04 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o4HLjQ6f035456 ; Mon, 17 May 2010 23:45:26 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o4HLjPwx088423 ; Mon, 17 May 2010 23:45:25 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o4HLjOk9029854 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Mon, 17 May 2010 23:45:24 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: "'Tom Tromey'" , , "'FPC Core Developer List'" References: <8830.7035308846$1273670829@news.gmane.org> <20100517172758.GJ2805@adacore.com> <000301caf5e7$222ac800$66805800$@muller@ics-cnrs.unistra.fr> <20100517174726.GK2805@adacore.com> In-Reply-To: <20100517174726.GK2805@adacore.com> Subject: RE: [RFA] dwarf debug format: Support DW_AT_variable_parameter attribute Date: Mon, 17 May 2010 21:48:00 -0000 Message-ID: <001201caf60a$43b76a00$cb263e00$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00372.txt.bz2 Whoops, you are right: this was Tom's question: >I wonder whether it is possible for such a parameter to be marked as >LOC_COMPUTED or LOC_OPTIMIZED_OUT by var_decode_location. If so then >changing the class to LOC_REF_ARG seems incorrect. I looked a little more into the sources and now understand that my patch is indeed wrong :( I hoped that simple case like variables in registers or at a fixed offset relative to stack would simply be treated as in stabs and assign a LOC_REGISTER or LOC_ARG SYMBOL_CLASS, but there is no such conversion ... See note line 8459 from dwarf2read.c source. /* NOTE drow/2002-01-30: It might be worthwhile to have a static expression evaluator, and use LOC_COMPUTED only when necessary (i.e. when the value of a register or memory location is referenced, or a thread-local block, etc.). Then again, it might not be worthwhile. I'm assuming that it isn't unless performance or memory numbers show me otherwise. */ I fear that my patch will have to wait until=20 this static expression evaluator is implemented... Let's drop this patch for now. Thanks for the clever question, Tom! Pierre > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Joel Brobecker > Envoy=E9=A0: Monday, May 17, 2010 7:47 PM > =C0=A0: Pierre Muller > Cc=A0: 'Tom Tromey'; gdb-patches@sourceware.org > Objet=A0: Re: [RFA] dwarf debug format: Support DW_AT_variable_parameter > attribute >=20 > > So, may I commit this patch? >=20 > As far as I can tell, there was a question from Tom that is still > unanswered... >=20 > -- > Joel