From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18015 invoked by alias); 11 Sep 2009 08:41:37 -0000 Received: (qmail 18006 invoked by uid 22791); 11 Sep 2009 08:41:36 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 08:41:30 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n8B8ek0K028004 ; Fri, 11 Sep 2009 10:40:46 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n8B8aZdT089322 ; Fri, 11 Sep 2009 10:36:35 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n8B8aZDM003637 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 11 Sep 2009 10:36:35 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Paul Pluzhnikov'" Cc: "'Joel Brobecker'" , "'Ulrich Weigand'" , "'gdb-patches ml'" , "'Tom Tromey'" , "'Jan Kratochvil'" References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> <20090909055824.GB11738@adacore.com> <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> <20090910182952.GK20694@adacore.com> <8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> <000c01ca32ac$0ca9f8b0$25fdea10$@u-strasbg.fr> <8ac60eac0909110029q1c88dcetdb644fa461fa545c@mail.gmail.com> <000f01ca32b3$0e6b5390$2b41fab0$@u-strasbg.fr> <8ac60eac0909110103l2b88dc95i2f3c238aa4be2ed0@mail.gmail.com> In-Reply-To: <8ac60eac0909110103l2b88dc95i2f3c238aa4be2ed0@mail.gmail.com> Subject: RE: [patch] Speed up find_pc_section Date: Fri, 11 Sep 2009 08:41:00 -0000 Message-ID: <001201ca32ba$f9060e70$eb122b50$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00314.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Paul Pluzhnikov > Envoy=E9=A0: Friday, September 11, 2009 10:03 AM > =C0=A0: Pierre Muller > Cc=A0: Joel Brobecker; Ulrich Weigand; gdb-patches ml; Tom Tromey; Jan > Kratochvil > Objet=A0: Re: [patch] Speed up find_pc_section >=20 > On Fri, Sep 11, 2009 at 12:39 AM, Pierre Muller strasbg.fr> wrote: >=20 > >> All overlaps are removed in filter_overlapping_sections, before the > >> first binary search is performed. > > > > =A0This is where I get lost: > > I see no code in filter_overlapping_sections > > that changes map_size, so how are these overlapping > > elements removed and what is put in their place? >=20 > Ah, that's a bug; thanks for catching it. > The filter_overlapping_sections was supposed to return 'j', not > 'map_size'. Maybe you could alter the complaint so that it becomes clear which of the two sections is discarded from the mapping? In your current patch, it isn't obvious. Pierre Muller Pascal language support maintainer for GDB