From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25139 invoked by alias); 15 Mar 2011 10:50:18 -0000 Received: (qmail 25129 invoked by uid 22791); 15 Mar 2011 10:50:17 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT,TW_BJ X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 10:50:12 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p2FAnvTK065024 ; Tue, 15 Mar 2011 11:49:58 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms4.u-strasbg.fr [130.79.204.13]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2FAnvxH077797 ; Tue, 15 Mar 2011 11:49:57 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2FAnt50019774 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Tue, 15 Mar 2011 11:49:56 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: References: <20110312015329.GA20179@sourceware.org> <010f01cbe157$aebb5cb0$0c321610$%muller@ics-cnrs.unistra.fr> <18667.385276831$1300008680@news.gmane.org> <001401cbe261$5490ec40$fdb2c4c0$%muller@ics-cnrs.unistra.fr> <83oc5dr6pj.fsf@gnu.org> <10281.0550401502$1300122152@news.gmane.org> In-Reply-To: Subject: [RFA] Fix formatting in [RFA-v2] Fix ARI warning about function call in first column Date: Tue, 15 Mar 2011 12:19:00 -0000 Message-ID: <001101cbe2fe$ba538f40$2efaadc0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00767.txt.bz2 > Pierre> +static struct varobj * varobj_add_child (struct varobj *var, > Pierre> + const char *name, > Pierre> + struct value *value); > > Extra space after the "*". > > Pierre> +extern struct hppa_objfile_private * > hppa_init_objfile_priv_data (struct > > Likewise. > > Pierre> +struct displaced_step_closure* > get_displaced_step_closure_by_addr > > Space is on the wrong side of the "*"; I know you didn't cause this but > if you are fixing the indentation anyway... > > Tom Is this OK like below? Or should I still add the function declarations on which the change is applied (which I did not add in my previous ChangeLog entry). Pierre ChangeLog entry: 2011-03-15 Pierre Muller Fix formatting of functions returning a pointer in previous commit. * varobj.c: Ditto. * hppa-tdep.h: Ditto. * inferior.h: Ditto. Index: hppa-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/hppa-tdep.h,v retrieving revision 1.42 diff -r1.42 hppa-tdep.h 243c243 < extern struct hppa_objfile_private * hppa_init_objfile_priv_data (struct objfile *objfile); --- > extern struct hppa_objfile_private *hppa_init_objfile_priv_data (struct objfile *objfile); Index: inferior.h =================================================================== RCS file: /cvs/src/src/gdb/inferior.h,v retrieving revision 1.153 diff -r1.153 inferior.h 369c369 < struct displaced_step_closure* get_displaced_step_closure_by_addr (CORE_ADDR addr); --- > struct displaced_step_closure *get_displaced_step_closure_by_addr (CORE_ADDR addr); Index: varobj.c =================================================================== RCS file: /cvs/src/src/gdb/varobj.c,v retrieving revision 1.173 diff -r1.173 varobj.c 299,301c299,301 < static struct varobj * varobj_add_child (struct varobj *var, < const char *name, < struct value *value); --- > static struct varobj *varobj_add_child (struct varobj *var, > const char *name, > struct value *value);