From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68136-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25159 invoked by alias); 3 Nov 2009 08:34:26 -0000
Received: (qmail 25151 invoked by uid 22791); 3 Nov 2009 08:34:25 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from dns.vtab.com (HELO oden.vtab.com) (62.20.90.195)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Nov 2009 08:34:20 +0000
Received: from oden.vtab.com (oden.vtab.com [127.0.0.1]) 	by oden.vtab.com (Postfix) with ESMTP id A2AF426EF72; 	Tue,  3 Nov 2009 09:34:16 +0100 (CET)
Received: from polhem (unknown [62.20.90.206]) 	(using TLSv1 with cipher AES128-SHA (128/128 bits)) 	(No client certificate requested) 	by oden.vtab.com (Postfix) with ESMTP id 7B76726EF66; 	Tue,  3 Nov 2009 09:34:16 +0100 (CET)
From: "Jakob Engblom" <jakob@virtutech.com>
To: "'Eli Zaretskii'" <eliz@gnu.org>, 	"'Michael Snyder'" <msnyder@vmware.com>
Cc: <gdb-patches@sourceware.org>, 	<glaw@undo-software.com>, 	<teawater@gmail.com>
References: <4AEDF9F4.9040207@vmware.com> <834opec530.fsf@gnu.org> <4AEE27E9.1070005@vmware.com> <831vkhd18a.fsf@gnu.org>
In-Reply-To: <831vkhd18a.fsf@gnu.org>
Subject: RE: [RFA] replay bookmarks
Date: Tue, 03 Nov 2009 08:34:00 -0000
Message-ID: <001101ca5c60$7220f9e0$5662eda0$@com>
MIME-Version: 1.0
Content-Type: text/plain; 	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00043.txt.bz2

> > >> Date: Sun, 01 Nov 2009 13:13:24 -0800
> > >> From: Michael Snyder <msnyder@vmware.com>
> > >>
> > >> +  add_com ("bookmark", class_bookmark, save_bookmark_command, _("\
> > >> +Set a bookmark.\n\
> > >
> > > This is way too short.  Suggest to expand a bit:
> > >
> > >   Set a bookmark in the inferior's execution history
> > >
> > >> +  add_com ("goto-bookmark", class_bookmark, goto_bookmark_command, _("\
> > >> +Go to bookmark <n>\n\
> > >
> > > Similarly here: such a short description is hardly useful, as it just
> > > repeats the name of the command.
> >
> > How about this?
> 
> Fine with me.
> 
> There are a few instances of user messages where the text is not
> marked by _().
> 
> Also, we will need an update for the manual, once this is approved.

Also, will this add corresponding operations to gdb-serial? That is necessary to
get this working for undodb, Simics, and similar remote-exec bookmarkable
targets.  I guess that also means VMWare, right?

/jakob