From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26171 invoked by alias); 19 Dec 2007 14:01:06 -0000 Received: (qmail 26162 invoked by uid 22791); 19 Dec 2007 14:01:05 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Dec 2007 14:00:59 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with ESMTP id AD8DC187023; Wed, 19 Dec 2007 15:05:05 +0100 (CET) From: "Pierre Muller" To: Cc: "'Daniel Jacobowitz'" , References: <1187298178.5853.11.camel@localhost> <1187365616.4520.14.camel@localhost> <20071011193558.GE30810@caradoc.them.org> <1192134591.18528.1.camel@localhost> <1194961811.4820.3.camel@localhost> <1195042801.4908.2.camel@localhost> <20071216214836.GE2618@caradoc.them.org> <1197894945.24027.8.camel@gargoyle> <000601c8423e$f49ca010$ddd5e030$@u-strasbg.fr> <1198072304.1209.21.camel@gargoyle> In-Reply-To: <1198072304.1209.21.camel@gargoyle> Subject: RE: [RFC/RFA] testsuite/gdb.base/watch_thread_num.exp: Fix test for systems having hidden threads Date: Wed, 19 Dec 2007 14:04:00 -0000 Message-ID: <001101c84247$986dc0e0$c94942a0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00304.txt.bz2 > -----Original Message----- > Hi Pierre, > > On Wed, 2007-12-19 at 13:59 +0100, Pierre Muller wrote: > > This test currently fails on cygwin target > > and it does by timeout's which means that it takes a lot of time... > > The reason of the failure is that > > thread #2 is a thread created internally by cygwin, > > for posix emulation, and thus never > > changes the value of the variable shared_var. > > Thanks for pointing this out. I wasn't aware of that fact. > > > * (gdb.base/watch_thread_num.exp): Add breakpoint at > > thread_function and record first explicitly generated > > thread number. > > Use that thread number for thread specific watchpoint test. > > Add iteration number to repetitive tests. > > Looks OK. Maybe just "Use thread number for testing" and "Add iteration > number" will do on those two phrases. > > +gdb_test "disable 2" "" "Disable breakpoint 2" > > Maybe a comment on why this is being explicitly disabled because of > Cygwin? Breakpoint 2 is now the breakpoint at thread_function, which is call for each newly created thread, but we only care to have one of those threads, that is the reason why I disabled it after getting one valid thread number. > The other portions of the patch look OK to me. > > The patch has 29 passes on PPC as well. Great, thanks for testing. Pierre