From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19390 invoked by alias); 3 Sep 2009 08:11:49 -0000 Received: (qmail 19363 invoked by uid 22791); 3 Sep 2009 08:11:48 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Sep 2009 08:11:41 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n838BbRY029872 ; Thu, 3 Sep 2009 10:11:37 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n838Bbfq057944 ; Thu, 3 Sep 2009 10:11:37 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n838BbZX047800 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 3 Sep 2009 10:11:37 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: , References: <20090730230505.22710.qmail@sourceware.org> In-Reply-To: <20090730230505.22710.qmail@sourceware.org> Subject: [ARI regression] in arm-tdep.c Date: Thu, 03 Sep 2009 08:11:00 -0000 Message-ID: <001001ca2c6e$294c4750$7be4d5f0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00081.txt.bz2 Hi Jules, your patch from august 31 add a new regression about use of abort() function See http://sourceware.org/gdb/current/ari/ As stated: Do not use abort, instead use internal_error; GDB should never abort Below is a proposition of patch, but as I have no precise idea of what=20 displaced_write_reg function does, it might be better if you commit a patch with a more adequate description of the problem, maybe something like=20 "wrong write_pc argument value in displaced_write_reg fuinction"? Could you please take care of this? Pierre Muller GDB ARI maintainer. Index: arm-tdep.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/arm-tdep.c,v retrieving revision 1.286 diff -u -p -r1.286 arm-tdep.c --- arm-tdep.c 14 Aug 2009 00:32:31 -0000 1.286 +++ arm-tdep.c 3 Sep 2009 08:01:10 -0000 @@ -2769,7 +2769,8 @@ displaced_write_reg (struct regcache *re break; default: - abort (); + internal_error (__FILE__, __LINE__, + _("Error inside displaced_write_reg function")); } dsc->wrote_to_pc =3D 1; > -----Message d'origine----- > De=A0: gdb-cvs-owner@sourceware.org [mailto:gdb-cvs-owner@sourceware.org] > De la part de jules@sourceware.org > Envoy=E9=A0: Friday, July 31, 2009 1:05 AM > =C0=A0: gdb-cvs@sourceware.org > Objet=A0: src/gdb ChangeLog arm-linux-tdep.c arm-tdep.c ... >=20 > CVSROOT: /cvs/src > Module name: src > Changes by: jules@sourceware.org 2009-07-30 23:05:05 >=20 > Modified files: > gdb : ChangeLog arm-linux-tdep.c arm-tdep.c > arm-tdep.h >=20 > Log message: > * arm-linux-tdep.c (arch-utils.h, inferior.h, gdbthread.h, > symfile.h): > Include files. > (arm_linux_cleanup_svc, arm_linux_copy_svc): New. > (cleanup_kernel_helper_return, arm_catch_kernel_helper_return): > New. > (arm_linux_displaced_step_copy_insn): New. > (arm_linux_init_abi): Initialise displaced stepping callbacks. > * arm-tdep.c (DISPLACED_STEPPING_ARCH_VERSION): New macro. > (ARM_NOP): New. > (displaced_read_reg, displaced_in_arm_mode, branch_write_pc) > (bx_write_pc, load_write_pc, alu_write_pc, displaced_write_reg) > (insn_references_pc, copy_unmodified, cleanup_preload, > copy_preload) > (copy_preload_reg, cleanup_copro_load_store, > copy_copro_load_store) > (cleanup_branch, copy_b_bl_blx, copy_bx_blx_reg, cleanup_alu_imm) > (copy_alu_imm, cleanup_alu_reg, copy_alu_reg) > (cleanup_alu_shifted_reg, copy_alu_shifted_reg, cleanup_load) > (cleanup_store, copy_extra_ld_st, copy_ldr_str_ldrb_strb) > (cleanup_block_load_all, cleanup_block_store_pc) > (cleanup_block_load_pc, copy_block_xfer, cleanup_svc, copy_svc) > (copy_undef, copy_unpred): New. > (decode_misc_memhint_neon, decode_unconditional) > (decode_miscellaneous, decode_dp_misc, decode_ld_st_word_ubyte) > (decode_media, decode_b_bl_ldmstm, decode_ext_reg_ld_st) > (decode_svc_copro, arm_process_displaced_insn) > (arm_displaced_init_closure, arm_displaced_step_copy_insn) > (arm_displaced_step_fixup): New. > (arm_gdbarch_init): Initialise max insn length field. > * arm-tdep.h (DISPLACED_TEMPS, DISPLACED_MODIFIED_INSNS): New > macros. > (displaced_step_closure, pc_write_style): New. > (arm_displaced_init_closure, displaced_read_reg) > (arm_process_displaced_insn, arm_displaced_init_closure) > (displaced_read_reg, displaced_write_reg, > arm_displaced_step_copy_insn) > (arm_displaced_step_fixup): Add prototypes. >=20 > Patches: > http://sources.redhat.com/cgi- > bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=3Dsrc&r1=3D1.10761&r2=3D1.1= 0762 > http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/arm-linux- > tdep.c.diff?cvsroot=3Dsrc&r1=3D1.69&r2=3D1.70 > http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/arm- > tdep.c.diff?cvsroot=3Dsrc&r1=3D1.284&r2=3D1.285 > http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/arm- > tdep.h.diff?cvsroot=3Dsrc&r1=3D1.36&r2=3D1.37