From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KWMYEFLs1WAROAAAWB0awg (envelope-from ) for ; Fri, 25 Jun 2021 10:46:42 -0400 Received: by simark.ca (Postfix, from userid 112) id 311E41F1F2; Fri, 25 Jun 2021 10:46:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5C9CA1EE14 for ; Fri, 25 Jun 2021 10:46:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B2C403853832 for ; Fri, 25 Jun 2021 14:46:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2C403853832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1624632400; bh=WxJeQck7UQBFpZYdjpNcmc2uOJ9zHfMpoSUXfgtnmkQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=KcigjCUIOqYD3YTGIER5ZkEMIxjK/cObsgjjQ9uXaQGRnll11Z+XT4L5R1ZoksALp J2A85w7HnufpNBeFvVC6F7fiufLnEDeFKV36ZV0TK3XNfGDpecg3A+OM8nebQuPS0u cOhzVl+iH2TIApwG/5rITD87bx9DC8LcGkapPvX8= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DDA96385800A for ; Fri, 25 Jun 2021 14:46:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDA96385800A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 15PEkGhE012463 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Jun 2021 10:46:21 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 15PEkGhE012463 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 27FEE1EE14; Fri, 25 Jun 2021 10:46:16 -0400 (EDT) Subject: Re: [RFC][gdb/testsuite] Remove read1 timeout factor from gdb.base/info-macros.exp To: Tom de Vries , gdb-patches@sourceware.org References: <20210624153449.GA30047@delia> Message-ID: <000fba5a-d926-27da-f313-94849cf7acea@polymtl.ca> Date: Fri, 25 Jun 2021 10:46:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210624153449.GA30047@delia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 25 Jun 2021 14:46:16 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-24 11:34 a.m., Tom de Vries wrote: > Hi, > > At the moment some check-read1 timeouts are handled like this in > gdb.base/info-macros.exp: > ... > gdb_test_multiple_with_read1_timeout_factor 10 "$test" $testname { > -re "$r1$r2$r3" { > pass $testname > } > -re ".*#define TWO.*\r\n$gdb_prompt" { > fail $testname > } > -re ".*#define THREE.*\r\n$gdb_prompt" { > fail $testname > } > -re ".*#define FOUR.*\r\n$gdb_prompt" { > fail $testname > } > } > ... > which is not ideal. > > We could use gdb_test_lines, but it currently doesn't support verifying > the absence of regexps, which is currently implemented using the clauses above > calling fail. > > Fix this by using gdb_test_lines and adding a -re-not syntax to > gdb_test_lines, such that we can do: > ... > gdb_test_lines $test $testname $r1.*$r2 \ > -re-not "#define TWO" \ > -re-not "#define THREE" \ > -re-not "#define FOUR" > ... > > Only removing one use of gdb_test_multiple_with_read1_timeout_factor in the > test-case for now. > > Tested on x86_64-linux, which make targets check and check-read1. > > Any comments? I don't see anything wrong with the patch, seems useful. Simon