RE: [RFA-v2] testsuite: Avoid auto-import warning on cygwin/mingw

Pierre Muller
2009-10-02T22:27:19Z

> > This confirms that the current additions to options
> > are finally discarded by the
> > set options $new_options
> > a few lines down,
> > and that my patch is correct, no?
>
> Yes. I would prefer then that the dead code isn't made
> live and untested for no good reason. I'd rather having it
> removed, or if you prefer, go ahead apply the patch you
> had before, the one that didn't touch the aix and irix bits, and
> I'll remove the dead code afterwards.

Ok,

Pierre

For the record, here is what I finally committed:

$ cvs diff -up ChangeLog commit.txt lib/gdb.exp
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.1979
diff -u -p -r1.1979 ChangeLog
--- ChangeLog 2 Oct 2009 21:28:34 -0000 1.1979
+++ ChangeLog 2 Oct 2009 22:22:38 -0000
@@ -1,4 +1,9 @@
2009-10-02 Pierre Muller <muller@ics.u-strasbg.fr>
+
+ * lib/gdb.exp (gdb_compile): Add --enable-auto-import option for
+ mingw and cygwin targets.
+
+2009-10-02 Pierre Muller <muller@ics.u-strasbg.fr>
Pedro Alves <pedro@codesourcery.com>

* lib/gdb.exp (gdb_compile): Avoid adding
Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.120
diff -u -p -r1.120 gdb.exp
--- lib/gdb.exp 2 Oct 2009 21:28:34 -0000 1.120
+++ lib/gdb.exp 2 Oct 2009 22:22:39 -0000
@@ -1731,7 +1731,10 @@ proc gdb_compile {source dest type optio
lappend options "additional_flags=-L${outdir}"
} elseif { [istarget "mips-sgi-irix*"] } {
lappend options "additional_flags=-rpath ${outdir}"
- }
+ } elseif { ([istarget "*-*-mingw*"]
+ || [istarget *-*-cygwin*]) } {
+ lappend new_options
"additional_flags=-Wl,--enable-auto-impo
rt"
+ }
}
} elseif { $opt == "shlib_load" } {
if { ([istarget "*-*-mingw*"]