From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15294 invoked by alias); 16 Jun 2009 23:54:38 -0000 Received: (qmail 15285 invoked by uid 22791); 16 Jun 2009 23:54:37 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Jun 2009 23:54:32 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n5GNsOdB034504 ; Wed, 17 Jun 2009 01:54:24 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n5GNsOw5078724 ; Wed, 17 Jun 2009 01:54:24 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n5GNsNNV034472 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 17 Jun 2009 01:54:23 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: , "'Eli Zaretskii'" References: <001401c9de9f$928b9f80$b7a2de80$@u-strasbg.fr> <200906162359.43456.pedro@codesourcery.com> <000601c9eed8$fcfaa0c0$f6efe240$@u-strasbg.fr> <200906170046.22746.pedro@codesourcery.com> In-Reply-To: <200906170046.22746.pedro@codesourcery.com> Subject: RE: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP Date: Tue, 16 Jun 2009 23:54:00 -0000 Message-ID: <000f01c9eedd$c8823790$5986a6b0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00421.txt.bz2 This is perfectly OK for me, could you check it in? Otherwise I can check it in tomorrow. Thanks for your replies Pierre > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: Wednesday, June 17, 2009 1:46 AM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org; 'Eli Zaretskii' > Objet=A0: Re: [PING][RFA-v2] Fix troubles with watchpoints in DJGPP >=20 > On Wednesday 17 June 2009 00:20:06, Pierre Muller wrote: > > + =A0/* On systems that load no shared libraries, like DJGPP target, > > + =A0 =A0 breakpoint_re_set is never called. > > + =A0 =A0 Call it now so that ordinary watchpoints get a chance to > > + =A0 =A0 become promoted to hardware watchpoints if the pushed target > > + =A0 =A0 supports hardware watchpoints. =A0*/ > > + =A0breakpoint_re_set (); > > + >=20 > Much, much better, thanks. "systems that load no shared libraries" > still isn't the right predicate, as I demonstrated with the > linux static executable, and the breakpoint_re_set call due to > adding the vsyscall page's symbols. I'd suggest expanding a bit > more. Something like: >=20 > /* If the user sets watchpoints before execution having started, > then she gets software watchpoints, because GDB can't know which > target will end up being pushed, or if it supports hardware > watchpoints or not. breakpoint_re_set takes care of promoting > watchpoints to hardware watchpoints if possible, however, if this > new inferior doesn't load shared libraries or we don't pull in > symbols from any other source on this target/arch, > breakpoint_re_set is never called. Call it now so that software > watchpoints get a chance to be promoted to hardware watchpoints > if the now pushed target supports hardware watchpoints. */ > breakpoint_re_set (); >=20 > (s/ordinary/software/. There's nothing unordinary about hardware > watchpoints) >=20 > -- > Pedro Alves