From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4800 invoked by alias); 23 Jun 2009 22:57:15 -0000 Received: (qmail 4791 invoked by uid 22791); 23 Jun 2009 22:57:15 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Jun 2009 22:57:07 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n5NMv0Hr028519 ; Wed, 24 Jun 2009 00:57:00 +0200 (CEST) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [IPv6:2001:660:2402:d::11]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n5NMv0hR002870 ; Wed, 24 Jun 2009 00:57:00 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n5NMuxYA047402 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 24 Jun 2009 00:57:00 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: Cc: "'Pedro Alves'" Subject: [RFA] Fix problem with extended-remote if multi_process is zero Date: Tue, 23 Jun 2009 22:57:00 -0000 Message-ID: <000e01c9f455$eaee40d0$c0cac270$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00639.txt.bz2 The patch below fixes a problem leading to a crash of gdbserver if target extended-remote is used on targets not supporting multi process. OK to commit? Pierre 2009-06-24 Pierre Muller * server.c (handle_v_kill): Pass signal_pid to kill_inferior if multi_process is zero. Index: src/gdb/gdbserver/server.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/server.c,v retrieving revision 1.99 diff -u -p -r1.99 server.c --- src/gdb/gdbserver/server.c 23 Jun 2009 15:12:44 -0000 1.99 +++ src/gdb/gdbserver/server.c 23 Jun 2009 22:49:34 -0000 @@ -1523,8 +1523,10 @@ handle_v_kill (char *own_buf) { int pid; char *p = &own_buf[6]; - - pid = strtol (p, NULL, 16); + if (multi_process) + pid = strtol (p, NULL, 16); + else + pid = signal_pid; if (pid != 0 && kill_inferior (pid) == 0) { last_status.kind = TARGET_WAITKIND_SIGNALLED;