From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26151 invoked by alias); 3 Sep 2009 07:56:53 -0000 Received: (qmail 26125 invoked by uid 22791); 3 Sep 2009 07:56:51 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_14,J_CHICKENPOX_91,J_CHICKENPOX_93 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Sep 2009 07:56:46 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n837ueq6086353 ; Thu, 3 Sep 2009 09:56:41 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n837udcX043393 ; Thu, 3 Sep 2009 09:56:39 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n837udXo089688 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 3 Sep 2009 09:56:39 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: , References: <20090806102838.12059.qmail@sourceware.org> In-Reply-To: <20090806102838.12059.qmail@sourceware.org> Subject: [ARI regression] About score-tdep commit Date: Thu, 03 Sep 2009 07:56:00 -0000 Message-ID: <000d01ca2c6c$1266fd70$3734f850$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00080.txt.bz2 Hi Don, looking at=20 http://sourceware.org/gdb/current/ari/ I found a revival of TARGET_HAS_HARDWARE_WATCHPOINTS=20 macros, which should not be there. your commit of score-tdep.h was apparently approved in march but you committed it only in august. In the mean time, the macro TARGET_HAS_HARDWARE_WATCHPOINTS has been removed and several other macros have been renamed TARGET_CAN_USE_HARDWARE_WATCHPOINT =3D> target_can_use_hardware_watchpoint STOPPED_BY_WATCHPOINT =3D> target_stopped_by_watchpoint HAVE_CONTINUABLE_HARDWARE_WATCHPOINT =3D> target_have_continuable_watchpoint TARGET_REGION_OK_FOR_HW_WATCHPOINT =3D> target_region_ok_for_hw_watchpoint Thus the current code is not functional. All the hardware watchpoint related macros that you set in score-tdep.c should be replaced by appropriate entry in a target_ops struct... But I saw no target_ops for your system, thus I don't really know how to fix your code. Could you try to look into this? Pierre Muller GDB ARI (Awk Regression Index) maintainer > -----Message d'origine----- > De=A0: gdb-cvs-owner@sourceware.org [mailto:gdb-cvs-owner@sourceware.org] > De la part de donlee@sourceware.org > Envoy=E9=A0: Thursday, August 06, 2009 12:29 PM > =C0=A0: gdb-cvs@sourceware.org > Objet=A0: src/gdb ChangeLog MAINTAINERS NEWS configure.t ... >=20 > CVSROOT: /cvs/src > Module name: src > Changes by: donlee@sourceware.org 2009-08-06 10:28:38 >=20 > Modified files: > gdb : ChangeLog MAINTAINERS NEWS configure.tgt > score-tdep.c score-tdep.h >=20 > Log message: > * score-tdep.c: Support a new Sunplus CT S+core variant, S+core > 3. > * score-tdep.h: Ditto. > * NEWS: Ditto. > * configure.tgt: Test do we have a simulator. > * MAINTAINERS: Add myself under target score >=20 > Patches: > http://sources.redhat.com/cgi- > bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=3Dsrc&r1=3D1.10781&r2=3D1.1= 0782 > http://sources.redhat.com/cgi- > bin/cvsweb.cgi/src/gdb/MAINTAINERS.diff?cvsroot=3Dsrc&r1=3D1.422&r2=3D1.4= 23 > http://sources.redhat.com/cgi- > bin/cvsweb.cgi/src/gdb/NEWS.diff?cvsroot=3Dsrc&r1=3D1.324&r2=3D1.325 > http://sources.redhat.com/cgi- > bin/cvsweb.cgi/src/gdb/configure.tgt.diff?cvsroot=3Dsrc&r1=3D1.223&r2=3D1= .224 > http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/score- > tdep.c.diff?cvsroot=3Dsrc&r1=3D1.20&r2=3D1.21 > http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/score- > tdep.h.diff?cvsroot=3Dsrc&r1=3D1.5&r2=3D1.6