From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 512 invoked by alias); 6 Nov 2012 15:47:51 -0000 Received: (qmail 503 invoked by uid 22791); 6 Nov 2012 15:47:50 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Nov 2012 15:47:44 +0000 Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qA6FlcAH050120 ; Tue, 6 Nov 2012 16:47:39 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms14.u-strasbg.fr [130.79.204.114]) by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qA6Flc8s011503 ; Tue, 6 Nov 2012 16:47:38 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id qA6FlbMZ014009 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Tue, 6 Nov 2012 16:47:37 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Mike Wrighton'" Cc: References: <50578114.3080307@mentor.com> <20120917202024.GA4423@host2.jankratochvil.net> <50578B21.4070101@mentor.com> In-Reply-To: <50578B21.4070101@mentor.com> Subject: About [commit] Hardware breakpoint errors patch, gdb/MAINTAINERS Date: Tue, 06 Nov 2012 15:47:00 -0000 Message-ID: <000c01cdbc36$0b2dcfe0$21896fa0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00115.txt.bz2 Hi Mike, Calls to warning or error function have their strings normally enclosed in _() to allow internationalization. This is missing in your patch and generated this automatic email about ARI regression. http://sourceware.org/ml/gdb-patches/2012-09/msg00232.html Is this intentional, or should I fix it by committing the patch below? Pierre Muller as ARI maintainer Index: remote.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.513 diff -u -p -r1.513 remote.c --- remote.c 2 Nov 2012 18:53:54 -0000 1.513 +++ remote.c 6 Nov 2012 15:39:49 -0000 @@ -8222,7 +8222,7 @@ remote_insert_hw_breakpoint (struct gdba { message =3D strchr (rs->buf + 2, '.'); if (message) - error ("Remote failure reply: %s", message + 1); + error (_("Remote failure reply: %s"), message + 1); } return -1; case PACKET_UNKNOWN: > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Mike Wrighton > Envoy=E9=A0: lundi 17 septembre 2012 22:42 > =C0=A0: Jan Kratochvil > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [commit] Hardware breakpoint errors patch, gdb/MAINTAINERS >=20 > On 09/17/2012 03:20 PM, Jan Kratochvil wrote: > > Hello Mike, > > > > On Mon, 17 Sep 2012 21:59:16 +0200, Mike Wrighton wrote: > >> I've committed the following patches to fix the hardware breakpoint > >> errors bug and add myself to the gdb/MAINTAINERS list (I had to > >> correct an error in the gdb/Changelog entry hence 2 patches for that > >> file). > > I see now that the real code commit from 12th September > > http://sourceware.org/ml/gdb-cvs/2012-09/msg00052.html > > > > also did not have a ChangeLog entry. Please add one, to the correct place > > chronologically according to the other commits there: > > http://sourceware.org/ml/gdb-cvs/2012-09/ > > > > > > Thanks, > > Jan >=20 > Hi Jan, >=20 > Ah yes, I added an entry to the main Changelog rather than the one in > the gdb subdirectory. I've moved it into the correct place now and > committed. Let me know if there's anything else I've missed. >=20 > Thanks, > Mike >=20 >=20 > Index: ChangeLog > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/ChangeLog,v > retrieving revision 1.1033 > diff -u -p -r1.1033 ChangeLog > --- ChangeLog 15 Sep 2012 17:11:26 -0000 1.1033 > +++ ChangeLog 17 Sep 2012 20:35:29 -0000 > @@ -13,16 +13,6 @@ > Add libgomp*.o to compare_exclusions for AIX. > * configure: Regenerate. >=20 > -2012-09-12 Mike Wrighton > - > - * gdb/remote.c (remote_insert_hw_breakpoint): Throw exception if > - there is an error inserting hardware breakpoints and use the > - error message from the target. > - > - * gdb/breakpoint.c (insert_bp_location, insert_breakpoint_locations): > - Catch this exception and print the error message contained within. > Do not > - print the default hardware error breakpoint message in this case. > - > 2012-08-26 H.J. Lu >=20 > PR binutils/4970 > Index: gdb/ChangeLog > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/ChangeLog,v > retrieving revision 1.14672 > diff -u -p -r1.14672 ChangeLog > --- gdb/ChangeLog 17 Sep 2012 19:29:52 -0000 1.14672 > +++ gdb/ChangeLog 17 Sep 2012 20:35:30 -0000 > @@ -179,6 +179,16 @@ > (DECLARE_REGISTRY): Declare struct TAG ## _data. Use the tagged > callback typedefs. >=20 > +2012-09-12 Mike Wrighton > + > + * remote.c (remote_insert_hw_breakpoint): Throw exception if > + there is an error inserting hardware breakpoints and use the > + error message from the target. > + > + * breakpoint.c (insert_bp_location, insert_breakpoint_locations): > + Catch this exception and print the error message contained within. > Do not > + print the default hardware error breakpoint message in this case. > + > 2012-09-12 Doug Evans >=20 > * dwarf2read.c (dwarf2_read_addr_index): Fix handling the case where >=20