[RFA-v2/ARI fix] Remove use of abort function in common/buffer.c

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

> We should just remove the abort; it's dead code.  xrealloc already handles
> that for us.  common/common-utils.c:xrealloc:

 Pedro, you are right of course...
Here is an update that just removes
the call to abort, and added a small
comment to explain.

Is this OK?

Pierre Muller
GDB pascal language maintainer



2012-05-22  Pierre Muller  <muller@ics.u-strasbg.fr>

        * common/buffer.c (buffer_grow): ARI fix: Remove unneeded
        call to abort.

Index: common/buffer.c
===================================================================
RCS file: /cvs/src/src/gdb/common/buffer.c,v
retrieving revision 1.3
diff -u -p -r1.3 buffer.c
--- common/buffer.c     11 May 2012 22:24:22 -0000      1.3
+++ common/buffer.c     22 May 2012 12:02:18 -0000
@@ -47,8 +47,8 @@ buffer_grow (struct buffer *buffer, cons
   while (buffer->used_size + size > new_buffer_size)
     new_buffer_size *= 2;
   new_buffer = xrealloc (buffer->buffer, new_buffer_size);
-  if (!new_buffer)
-    abort ();
+  /* new_buffer is non NULL otherwise
+     xrealloc calls malloc_failure which does not return here.  */
   memcpy (new_buffer + buffer->used_size, data, size);
   buffer->buffer = new_buffer;
   buffer->buffer_size = new_buffer_size;