From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28145 invoked by alias); 4 Jan 2011 19:19:29 -0000 Received: (qmail 28137 invoked by uid 22791); 4 Jan 2011 19:19:28 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Jan 2011 19:19:22 +0000 Received: from md1.u-strasbg.fr (md1.u-strasbg.fr [IPv6:2001:660:2402::186]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p04JJIY6076847 ; Tue, 4 Jan 2011 20:19:19 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms2.u-strasbg.fr [130.79.204.11]) by md1.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p04JJIxA048203 ; Tue, 4 Jan 2011 20:19:18 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p04JJGT3071510 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Tue, 4 Jan 2011 20:19:17 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Michael Snyder'" , References: <4D237089.1080309@vmware.com> In-Reply-To: <4D237089.1080309@vmware.com> Subject: RE: [patch] Shorten lines of >= 80 columns. Date: Tue, 04 Jan 2011 19:19:00 -0000 Message-ID: <000c01cbac44$48830210$d9890630$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00064.txt.bz2 I thought that they were already considered as obvious, but I still have a remark about one of your changes: @@ -632,8 +633,8 @@ gen_var_ref (struct gdbarch *gdbarch, st break; =20 case LOC_CONST_BYTES: - internal_error (__FILE__, __LINE__, - _("gen_var_ref: LOC_CONST_BYTES symbols are not supported")); + internal_error (__FILE__, __LINE__, _("\ +gen_var_ref: LOC_CONST_BYTES symbols are not supported")); I think this kind of changes confuses cvs for the 'cvs diff -u -p': it might regard the new line +gen_var_ref: LOC_CONST_BYTES symbols are not supported")); as a new starting function line and report a wrong function name... Of course not really for your example here, as the start of the line is the name of the function itself... But I remember having seen wrong function name reported with 'cvs -u -p' due to the use of '_("\' construct which force starting next line without=20 spaces... Pierre Muller GDB pascal language maintainer =20 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Michael Snyder > Envoy=E9=A0: mardi 4 janvier 2011 20:10 > =C0=A0: gdb-patches@sourceware.org > Objet=A0: [patch] Shorten lines of >=3D 80 columns. >=20 > I would like to propose that this type of change be regarded as > "obvious".