From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31202 invoked by alias); 23 Jun 2010 15:31:29 -0000 Received: (qmail 31193 invoked by uid 22791); 23 Jun 2010 15:31:28 -0000 X-SWARE-Spam-Status: No, hits=0.1 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT,RCVD_IN_JMF_BL X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Jun 2010 15:31:24 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o5NFVGTK074872 ; Wed, 23 Jun 2010 17:31:17 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms6.u-strasbg.fr [IPv6:2001:660:2402:d::15]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o5NFVGT1045492 ; Wed, 23 Jun 2010 17:31:16 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o5NFVF7a025943 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 23 Jun 2010 17:31:16 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Pedro Alves'" , References: <000901cb12dc$40c1f830$c245e890$@muller@ics-cnrs.unistra.fr> <201006231542.12328.pedro@codesourcery.com> In-Reply-To: <201006231542.12328.pedro@codesourcery.com> Subject: RE: [RFA] testsuite avoid tcl error in gdb.threads/gcore-thread.exp Date: Wed, 23 Jun 2010 15:31:00 -0000 Message-ID: <000c01cb12e9$26edf500$74c9df00$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00501.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Pedro Alves > Envoy=E9=A0: Wednesday, June 23, 2010 4:42 PM > =C0=A0: gdb-patches@sourceware.org > Cc=A0: Pierre Muller > Objet=A0: Re: [RFA] testsuite avoid tcl error in gdb.threads/gcore- > thread.exp >=20 > On Wednesday 23 June 2010 14:59:09, Pierre Muller wrote: >=20 > > Tested on gcc16 (it works again, hurrah!) > > no changes. >=20 > I, and more importantly I guess anyone reading the archives in a > few years, don't know what gcc16 is. I guess it to be a machine in > the gcc compile farm, and I guess it to be running linux, but I don't > know for sure. I don't know if it is x86, x86-64 or something else. > Can > you please state x86_64-linux, or something like that instead of > assuming everyone else is using the gcc compile farm? Sorry,=20 yes indeed gcc16 is just one of the machine of the gcc compile farm, and it is a linux box base on a x86_64 CPU. =20 > > OK to commit? >=20 > Yes, thanks.=20 Thanks for the approval, patch committed. > I was going to suggest fixing gcore.exp too, but > it was already fixed similarly at some point: >=20 > 2007-05-14 Markus Deuling >=20 > * gdb.base/gcore.exp: Initialize variable core_supported. >=20 > > set escapedfilename [string_to_regexp > ${objdir}/${subdir}/gcore.test] > > # Drop corefile > > +global core_supported > > +set core_supported 0 > > + >=20 > Pedantically, you don't need that "global" statement anymore. I still didn't really understand this: when I run a testsuite with 'make check'. All individual tests are run from runtest script which itself uses runtest procedure to execute each .exp file using the source command. Thus I was thinking that the code=20 inside each .exp file was not at global level, but only at 'runtest procedure level', and I am not even sure which level that procedure runs. Could someone explain to me why we are for sure at global level when a .exp file is sourced? Pierre