From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7706 invoked by alias); 11 Sep 2009 06:51:03 -0000 Received: (qmail 7698 invoked by uid 22791); 11 Sep 2009 06:51:03 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Sep 2009 06:50:58 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n8B6nojh075069 ; Fri, 11 Sep 2009 08:49:50 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from mailserver.u-strasbg.fr (ms1.u-strasbg.fr [IPv6:2001:660:2402:d::10]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n8B6nlAZ007008 ; Fri, 11 Sep 2009 08:49:47 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (www-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n8B6nkZ9021403 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Fri, 11 Sep 2009 08:49:46 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Paul Pluzhnikov'" , "'Joel Brobecker'" Cc: "'Ulrich Weigand'" , "'gdb-patches ml'" , "'Tom Tromey'" , "'Jan Kratochvil'" References: <8ac60eac0908201340k6b759eb5o9bb73c8f473d8785@mail.gmail.com> <200908211130.n7LBUCJc011108@d12av02.megacenter.de.ibm.com> <8ac60eac0908231548x135edf2doa04fa59a49455bcd@mail.gmail.com> <8ac60eac0908260020l4200cf84v2686a76b5858d13@mail.gmail.com> <20090909055824.GB11738@adacore.com> <8ac60eac0909101036r101263e7qd11c1a69f13008f1@mail.gmail.com> <20090910182952.GK20694@adacore.com> <8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> In-Reply-To: <8ac60eac0909101829g5384d665gdab27526fe95c27c@mail.gmail.com> Subject: RE: [patch] Speed up find_pc_section Date: Fri, 11 Sep 2009 06:51:00 -0000 Message-ID: <000c01ca32ac$0ca9f8b0$25fdea10$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00300.txt.bz2 The patch looks OK (not that I have any say on this), but I am still puzzled by what can happen if you have overlapping sections in the end. Is the CORE_ADDR to section mapping still deterministic in that case? Using binary search for ill order item can lead to different results if you add items to the list, no? And I suspect that dynamic loading of library can add items to the list with running a debuggee, thus leading to a different result before and after that loading for the same CORE_ADDR. Shouldn't we by brute force shorten one of the two overlapping sections to remove that error? If I understood your patch correctly, it doesn't do that for now. Please tell me if I am wrong. Adding a simple obj_section_endaddr (sect1):= sect2_addr; after the complaint should be enough to be sure that the binary search is deterministic, no? Pierre Muller Pascal language support maintainer for GDB