From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22591 invoked by alias); 8 Apr 2014 08:09:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22581 invoked by uid 89); 8 Apr 2014 08:09:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.217) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Apr 2014 08:09:55 +0000 Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id 6B05C20A5E; Tue, 8 Apr 2014 10:09:52 +0200 (CEST) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 5BA6520C26; Tue, 8 Apr 2014 10:09:52 +0200 (CEST) Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206]) by mr7.u-strasbg.fr (Postfix) with ESMTP id 1342220A5E; Tue, 8 Apr 2014 10:09:48 +0200 (CEST) Received: from ms16.u-strasbg.fr (ms16.u-strasbg.fr [130.79.204.116]) by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id s3889lXj014057 ; Tue, 8 Apr 2014 10:09:47 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by ms16.u-strasbg.fr (Postfix) with ESMTPSA id E7D291FD5C; Tue, 8 Apr 2014 10:09:44 +0200 (CEST) From: "Pierre Muller" To: "'Yao Qi'" , "'Joel Brobecker'" Cc: References: <1395712934-29531-1-git-send-email-yao@codesourcery.com> <533A2362.3030405@codesourcery.com> <20140407163922.GB4250@adacore.com> <53439192.9040801@codesourcery.com> In-Reply-To: <53439192.9040801@codesourcery.com> Subject: RE: [PATCH] [testsuite] Disable Ctrl-V use for mingw hosts. Date: Tue, 08 Apr 2014 08:09:00 -0000 Message-ID: <000901cf5301$e76396d0$b62ac470$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-04/txt/msg00094.txt.bz2 Hi all, the comment is a more useful addition to the patch than the change itself, so please don't forget to add your name to mine in the ChangeLog entry! Pierre Muller > -----Message d'origine----- > De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Yao Qi > Envoy=C3=A9 : mardi 8 avril 2014 08:05 > =C3=80 : Joel Brobecker > Cc : gdb-patches@sourceware.org > Objet : Re: [PATCH] [testsuite] Disable Ctrl-V use for mingw hosts. >=20 > On 04/08/2014 12:39 AM, Joel Brobecker wrote: > > Sorry about the wait. OK, but with a small change in the comment > > to say that the ctrl-v character is not only unnecessary on MinGW > > but actually harmful for the test because that character isn't > > recognized as an escape character. >=20 > OK, comments are updated. Patch below is pushed in. >=20 > > > > It'd be nice to know when @ is actually an escape character (just > > thinking out loud, not asking you to do the research - a google > > research doesn't quite clarify this for me). >=20 > I don't know either. >=20 > -- > Yao (=E9=BD=90=E5=B0=A7) >=20 > gdb/testsuite: >=20 > 2014-04-08 Pierre Muller >=20 > * gdb.base/printcmds.exp (test_artificial_arrays): Disable > Ctrl-V use for mingw hosts. > --- > gdb/testsuite/gdb.base/printcmds.exp | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) >=20 > diff --git a/gdb/testsuite/gdb.base/printcmds.exp > b/gdb/testsuite/gdb.base/printcmds.exp > index 8f38aca..3253d91 100644 > --- a/gdb/testsuite/gdb.base/printcmds.exp > +++ b/gdb/testsuite/gdb.base/printcmds.exp > @@ -631,8 +631,16 @@ proc test_print_typedef_arrays {} { >=20 > proc test_artificial_arrays {} { > # Send \026@ instead of just @ in case the kill character is @. > - gdb_test_escape_braces "p int1dim\[0\]\026@2" " =3D {0, 1}" {p > int1dim[0]@2} > - gdb_test_escape_braces "p int1dim\[0\]\026@2\026@3" \ > + # \026 (ctrl-v) is to escape the next character (@), but it is > + # not only unnecessary to do so on MingW hosts, but also harmful > + # for the test because that character isn't recognized as an > + # escape character. > + set ctrlv "\026" > + if [ishost *-*-mingw*] { > + set ctrlv "" > + } > + gdb_test_escape_braces "p int1dim\[0\]${ctrlv}@2" " =3D {0, 1}" {p > int1dim[0]@2} > + gdb_test_escape_braces "p int1dim\[0\]${ctrlv}@2${ctrlv}@3" \ > "({{0, 1}, {2, 3}, {4, 5}}|\[Cc\]annot.*)" \ > {p int1dim[0]@2@3} > gdb_test_escape_braces {p/x (short [])0x12345678} \ > -- > 1.8.1.4