From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4081 invoked by alias); 1 Oct 2013 13:39:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4072 invoked by uid 89); 1 Oct 2013 13:39:39 -0000 Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2013 13:39:39 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL,BAYES_00,LOTS_OF_MONEY,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id C9464140A80; Tue, 1 Oct 2013 15:39:35 +0200 (CEST) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id B92BA1409A2; Tue, 1 Oct 2013 15:39:35 +0200 (CEST) Received: from md13.u-strasbg.fr (md13.u-strasbg.fr [130.79.200.248]) by mr2.u-strasbg.fr (Postfix) with ESMTP id 8FDC1140B90; Tue, 1 Oct 2013 15:39:33 +0200 (CEST) Received: from ms18.u-strasbg.fr (ms18.u-strasbg.fr [130.79.204.118]) by md13.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r91DdXv4023066 ; Tue, 1 Oct 2013 15:39:33 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by ms18.u-strasbg.fr (Postfix) with ESMTPSA id 029F91FD77; Tue, 1 Oct 2013 15:39:31 +0200 (CEST) From: "Pierre Muller" To: "'Keith Seitz'" Cc: "'gdb-patches'" References: <002901cebaf2$35ec65a0$a1c530e0$@muller@ics-cnrs.unistra.fr> <003b01cebaf3$a2d79620$e886c260$@muller@ics-cnrs.unistra.fr> <524A2329.3030706@redhat.com> In-Reply-To: <524A2329.3030706@redhat.com> Subject: RE: [RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp for mingw hosts. Date: Tue, 01 Oct 2013 13:39:00 -0000 Message-ID: <000901cebeab$a83936d0$f8aba470$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-10/txt/msg00049.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Keith Seitz > Envoy=E9=A0: mardi 1 octobre 2013 03:20 > =C0=A0: Pierre Muller > Cc=A0: 'gdb-patches' > Objet=A0: Re: [RFC 6/6] Fix remaining failures in gdb.base/printcmds.exp = for > mingw hosts. >=20 > Hi, Pierre, >=20 > On 09/26/2013 01:04 PM, Pierre Muller wrote: > > The first part has to do with the fact that GDB prints > > the memory address and the closest symbol while the test > > doesn't cope for this. > > I simply fixed this by setting/unsetting printing of > > addresses and symbols at specific locations. >=20 > Can you provide an example? I notice no difference on linux with/without > those options set. Is the output really different on MinGW? [I wouldn't > have guessed that they are.] This is what I get if I remove this part 6 of the patch series: $ grep -C 3 FAIL gdb.log (gdb) PASS: gdb.base/printcmds.exp: p 1.5l p 0x1.1 Invalid number "0x1.1". (gdb) XFAIL: gdb.base/printcmds.exp: p 0x1.1 p 123DEADBEEF Invalid number "123DEADBEEF". (gdb) PASS: gdb.base/printcmds.exp: reject p 123DEADBEEF -- (gdb) PASS: gdb.base/printcmds.exp: set print elements 0 p teststring $554 =3D <__cygwin_cxx_malloc+128> "teststring contents" (gdb) FAIL: gdb.base/printcmds.exp: p teststring with elements set to 0 set print elements 1 (gdb) PASS: gdb.base/printcmds.exp: set print elements 1 p teststring $555 =3D <__cygwin_cxx_malloc+128> "t"... (gdb) FAIL: gdb.base/printcmds.exp: p teststring with elements set to 1 set print elements 5 (gdb) PASS: gdb.base/printcmds.exp: set print elements 5 p teststring $556 =3D <__cygwin_cxx_malloc+128> "tests"... (gdb) FAIL: gdb.base/printcmds.exp: p teststring with elements set to 5 set print elements 19 (gdb) PASS: gdb.base/printcmds.exp: set print elements 19 p teststring $557 =3D <__cygwin_cxx_malloc+128> "teststring contents" (gdb) FAIL: gdb.base/printcmds.exp: p teststring with elements set to 19 set print elements 20 (gdb) PASS: gdb.base/printcmds.exp: set print elements 20 p teststring $558 =3D <__cygwin_cxx_malloc+128> "teststring contents" (gdb) FAIL: gdb.base/printcmds.exp: p teststring with elements set to 20 set print elements 8 (gdb) PASS: gdb.base/printcmds.exp: set print elements 8 p &ctable1[0] -- (gdb) PASS: gdb.base/printcmds.exp: set print null-stop off p int1dim[0]@2 Invalid character '' in expression. (gdb) FAIL: gdb.base/printcmds.exp: p int1dim[0]@2 p int1dim[0]@2@3 Invalid character '' in expression. (gdb) FAIL: gdb.base/printcmds.exp: p int1dim[0]@2@3 p/x (short [])0x12345678 $607 =3D {0x5678, 0x1234} (gdb) set print elements 24 =20 The last two are due to the Ctrl-V problem, the others are due to the fact that the teststring is close to an address __cygwin_cxx_malloc (this is with the cygwin gcc used instead of the i686-w64-mingw32-gcc...) Well, in fact, those 5 errors disappear with the cross-compiler, but they are also present when I run the test for a native cygwin debugger. > In any case, this bit seems harmless enough. If you say it fixes > problems, I believe you, and I'm all for it! >=20 > > The last errors were generated by the use of Ctrl-V > > to avoid problems with possible association of @ to kill command. > > mingw GDB doesn't handle this Ctrl-V, so I conditionally removed it for > > *-*-mingw* hosts. >=20 > This isn't so much a question for you specifically, but I thought I'd > throw this out to the greater wisdom of the list. >=20 > I searched around the test suite and found a bunch of places where this > character is used without the ^V hack. Is it (still) necessary at all? > Perhaps we can just get rid of it entirely? I have no idea... I just played it save by disabling only for MinGW hosts... =20 > Otherwise, given the harmless nature of the changes, I'd recommend that > a maintainer approve this. Thanks again for all this reviews, Pierre