From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22856 invoked by alias); 10 Jan 2013 12:28:05 -0000 Received: (qmail 22848 invoked by uid 22791); 10 Jan 2013 12:28:04 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 Jan 2013 12:27:59 +0000 Received: from md16.u-strasbg.fr (md16.u-strasbg.fr [130.79.200.206]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r0ACRYx2004776 ; Thu, 10 Jan 2013 13:27:35 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms14.u-strasbg.fr [130.79.204.114]) by md16.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r0ACRWiZ011309 ; Thu, 10 Jan 2013 13:27:32 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r0ACRUVB008207 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) ; Thu, 10 Jan 2013 13:27:31 +0100 (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Eli Zaretskii'" , "'Andreas Schwab'" Cc: References: <001201cde13f$af3ad4b0$0db07e10$%muller@ics-cnrs.unistra.fr> <837go8pnxn.fsf@gnu.org> <834njcp160.fsf@gnu.org> In-Reply-To: <834njcp160.fsf@gnu.org> Subject: RE: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if statement Date: Thu, 10 Jan 2013 12:28:00 -0000 Message-ID: <000901cdef2d$dd0f32e0$972d98a0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00196.txt.bz2 Hi all, I would like to know what the status of this patch is, and more generally of the ARI rule: "Avoid assignment inside if statement". Eli wanted to challenge this rule, but others seems to be in favor... I really do find code easier to read if assignments are done before the if statement, but this is due to my pascal background, which forbids it. =20 Pierre Muller, as ARI maintainer. =20=20 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Eli Zaretskii > Envoy=E9=A0: lundi 24 d=E9cembre 2012 04:41 > =C0=A0: Andreas Schwab > Cc=A0: pierre.muller@ics-cnrs.unistra.fr; gdb-patches@sourceware.org > Objet=A0: Re: [RFA] (cli/cli-cmds.c) ARI fix: Avoid assignment inside if > statement >=20 > > From: Andreas Schwab > > Cc: Pierre Muller , gdb- > patches@sourceware.org > > Date: Sun, 23 Dec 2012 23:28:45 +0100 > > > > Eli Zaretskii writes: > > > > > Since when is that bad C, so much so that we would need to enforce it? > > > > It's part of the GNU coding standards. >=20 > Which says "Try not to...". >=20 > FWIW, Emacs sources are replete with such assignments, and I don't see > anything wrong with that in the first place. >=20 > So yes, I guess I'm challenging this ARI rule.