From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92773-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23246 invoked by alias); 17 Jul 2012 03:05:53 -0000
Received: (qmail 23233 invoked by uid 22791); 17 Jul 2012 03:05:52 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MSGID_MULTIPLE_AT,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_NO
X-Spam-Check-By: sourceware.org
Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Jul 2012 03:05:40 +0000
Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 17 Jul 2012 04:05:37 +0100
Received: from shawin053 ([10.164.2.89]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0);	 Tue, 17 Jul 2012 04:06:48 +0100
From: "Terry Guo" <terry.guo@arm.com>
To: "'Sergio Durigan Junior'" <sergiodj@redhat.com>
Cc: "Eli Zaretskii" <eliz@gnu.org>,	<gdb-patches@sourceware.org>
References: <000001cd5338$ded61b20$9c825160$%guo@arm.com>	<83hatw8zn1.fsf@gnu.org> <000301cd59bd$ce1c8900$6a559b00$%guo@arm.com>	<000101cd5f22$2371cdc0$6a556940$%guo@arm.com> <83k3yab0x6.fsf@gnu.org>	<000301cd5fcf$838d31b0$8aa79510$%guo@arm.com> <83ehohblor.fsf@gnu.org>	<000001cd6317$2d714cd0$8853e670$@guo@arm.com> <m38vejuqfd.fsf@redhat.com>
In-Reply-To: <m38vejuqfd.fsf@redhat.com>
Subject: RE: [PATCH]Fix that GDB will get hang on Windows when using pipe to get stdout and stderr from stub
Date: Tue, 17 Jul 2012 03:05:00 -0000
Message-ID: <000901cd63c9$34968b30$9dc3a190$@guo@arm.com>
MIME-Version: 1.0
X-MC-Unique: 112071704053701401
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00229.txt.bz2

> > +/* Read any error output we might have.  */
> > +
> > +static void
> > +ser_base_read_error_fd (struct serial *scb, int close_fd)
> > +{
> > +  if (scb->error_fd !=3D -1)
> > +    {
> > +      ssize_t s;
> > +      char buf[GDB_MI_MSG_WIDTH + 1];
> > +
> > +      for (;;)
> > +        {
> > +         char *current;
>=20
> I notice you are not following the convention of converting 8 spaces to
> a TAB character here and everywhere else.  Can you please fix it?
> After
> that, I can commit the patch for (if you don't have the permission yet).
>=20

Hi Sergio,

Thanks very much. I will fix them and re-send the patch for review.

BR,
Terry