From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5859 invoked by alias); 2 Oct 2009 22:27:19 -0000 Received: (qmail 5850 invoked by uid 22791); 2 Oct 2009 22:27:18 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Oct 2009 22:27:13 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n92MQsMY053325 ; Sat, 3 Oct 2009 00:26:54 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n92MQrLd040385 ; Sat, 3 Oct 2009 00:26:54 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n92MQqfa028303 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Sat, 3 Oct 2009 00:26:53 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Pedro Alves'" Cc: , References: <000f01ca42e3$e13cad60$a3b60820$@u-strasbg.fr> <000601ca43a8$49a83e90$dcf8bbb0$@u-strasbg.fr> <200910022318.56590.pedro@codesourcery.com> In-Reply-To: <200910022318.56590.pedro@codesourcery.com> Subject: RE: [RFA-v2] testsuite: Avoid auto-import warning on cygwin/mingw Date: Fri, 02 Oct 2009 22:27:00 -0000 Message-ID: <000901ca43af$7c096a10$741c3e30$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00078.txt.bz2 > > This confirms that the current additions to options > > are finally discarded by the > > set options $new_options > > a few lines down, > > and that my patch is correct, no? > > Yes. I would prefer then that the dead code isn't made > live and untested for no good reason. I'd rather having it > removed, or if you prefer, go ahead apply the patch you > had before, the one that didn't touch the aix and irix bits, and > I'll remove the dead code afterwards. Ok, Pierre For the record, here is what I finally committed: $ cvs diff -up ChangeLog commit.txt lib/gdb.exp Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v retrieving revision 1.1979 diff -u -p -r1.1979 ChangeLog --- ChangeLog 2 Oct 2009 21:28:34 -0000 1.1979 +++ ChangeLog 2 Oct 2009 22:22:38 -0000 @@ -1,4 +1,9 @@ 2009-10-02 Pierre Muller + + * lib/gdb.exp (gdb_compile): Add --enable-auto-import option for + mingw and cygwin targets. + +2009-10-02 Pierre Muller Pedro Alves * lib/gdb.exp (gdb_compile): Avoid adding Index: lib/gdb.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v retrieving revision 1.120 diff -u -p -r1.120 gdb.exp --- lib/gdb.exp 2 Oct 2009 21:28:34 -0000 1.120 +++ lib/gdb.exp 2 Oct 2009 22:22:39 -0000 @@ -1731,7 +1731,10 @@ proc gdb_compile {source dest type optio lappend options "additional_flags=-L${outdir}" } elseif { [istarget "mips-sgi-irix*"] } { lappend options "additional_flags=-rpath ${outdir}" - } + } elseif { ([istarget "*-*-mingw*"] + || [istarget *-*-cygwin*]) } { + lappend new_options "additional_flags=-Wl,--enable-auto-impo rt" + } } } elseif { $opt == "shlib_load" } { if { ([istarget "*-*-mingw*"]