From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-115945-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4948 invoked by alias); 16 Sep 2014 13:23:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4936 invoked by uid 89); 16 Sep 2014 13:23:54 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_50,MSGID_MULTIPLE_AT autolearn=no version=3.3.2
X-HELO: mailhost.u-strasbg.fr
Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Sep 2014 13:23:52 +0000
Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1])	by antispam (Postfix) with ESMTP id DA420221354;	Tue, 16 Sep 2014 15:23:49 +0200 (CEST)
Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1])	by antivirus (Postfix) with ESMTP id CB4A8220FB9;	Tue, 16 Sep 2014 15:23:49 +0200 (CEST)
Received: from lmr.u-strasbg.fr (lmr1.u-strasbg.fr [172.30.21.1])	by mr8.u-strasbg.fr (Postfix) with ESMTP id A14AA221354;	Tue, 16 Sep 2014 15:23:47 +0200 (CEST)
Received: from lmr.u-strasbg.fr (localhost [127.0.0.1])	by antivirus (Postfix) with ESMTP id 6D3A7DC;	Tue, 16 Sep 2014 15:23:47 +0200 (CEST)
Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225])	(Authenticated sender: mullerp)	by lmr1.u-strasbg.fr (Postfix) with ESMTPSA id 25BFBE4;	Tue, 16 Sep 2014 15:23:45 +0200 (CEST)
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <palves@redhat.com>,	<gdb-patches@sourceware.org>
References: <1410873512-762-1-git-send-email-palves@redhat.com>
In-Reply-To: <1410873512-762-1-git-send-email-palves@redhat.com>
Subject: RE: [pushed] Add test to make sure GDB knows which "kind" of watchpoint the target has
Date: Tue, 16 Sep 2014 13:23:00 -0000
Message-ID: <000601cfd1b1$718bd600$54a38200$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain;	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-09/txt/msg00536.txt.bz2

Hi Pedro,

I think there is a typo inside this:
> +	set sw_watch_pc [get_pc "get sw watchpoint PC"]
> +
> +	delete_breakpoints
> +
> +	# Allow hardware watchpoints again.
> +	gdb_test_no_output "set can-use-hw-watchpoints 1"
> +
> +	gdb_test "watch global" \
> +	    "Hardware watchpoint .*: global" \
> +	    "set hardware watchpoint on global variable"
> +
> +	gdb_test "continue" \
> +	    "Hardware watchpoint .*: global.*Old value = 1.*New value =
> 2.*set_global \\(val=2\\).*$srcfile.*" \
> +	    "hardware watchpoint triggers"
> +
> +	set hw_watch_pc [get_pc "get hw watchpoint PC"]
> +
> +	gdb_assert {$sw_watch_pc == $sw_watch_pc} "hw watchpoint stops at
> right instruction"
  Shouldn't this be
{$sw_watch_pc == $hw_watch_pc}?


Pierre Muller