From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79602-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12125 invoked by alias); 14 Mar 2011 12:34:31 -0000
Received: (qmail 11963 invoked by uid 22791); 14 Mar 2011 12:34:31 -0000
X-SWARE-Spam-Status: No, hits=-1.3 required=5.0	tests=AWL,BAYES_00,MSGID_MULTIPLE_AT
X-Spam-Check-By: sourceware.org
Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.156)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 12:34:25 +0000
Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187])           by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id p2ECYFFo013523           ; Mon, 14 Mar 2011 13:34:15 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from mailserver.u-strasbg.fr (ms6.u-strasbg.fr [130.79.204.15])           by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2ECYEvF036599           ; Mon, 14 Mar 2011 13:34:14 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN)          by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id p2ECYDua013294 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO)          ; Mon, 14 Mar 2011 13:34:13 +0100 (CET) (envelope-from pierre.muller@ics-cnrs.unistra.fr)
From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pedro Alves'" <pedro@codesourcery.com>, <gdb-patches@sourceware.org>,        "'Eli Zaretskii'" <eliz@gnu.org>
References: <20110312015329.GA20179@sourceware.org> <006701cbe220$a1a8dba0$e4fa92e0$@muller@ics-cnrs.unistra.fr> <E1Pz5v6-0002FS-Es@fencepost.gnu.org> <201103141213.43979.pedro@codesourcery.com>
In-Reply-To: <201103141213.43979.pedro@codesourcery.com>
Subject: RE: New ARI warning Sat Mar 12 01:53:29 UTC 2011
Date: Mon, 14 Mar 2011 12:49:00 -0000
Message-ID: <000601cbe244$22256280$66702780$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain;	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00715.txt.bz2

> But it's what we do all over.  We do have the rule that
> grep "^foofunc" should only match function definitions, not
> declarations.  Here in gdbint.texinfo:
> 
> "A function declaration should not have its name in column zero.  A
> function definition should have its name in column zero."

  Thank you for finding this out...
This is clearer than what I try to explain to Eli before.

  Eli, do you agree with this statement 
in gdbint.textinfo or should it be modified?

  Would you like to enhance it to specify what to do if
the whole function declaration
TYPE NAME (PARAMS);
doesn't fit into a 80 columns line?

 I am willing to adapt the ARI rule to such recommendations.

Pierre